Enable iterating over roots from helper threads by moving stack walking.

runtime/vm/thread_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/isolate.h"
 #include "vm/lockers.h"
 #include "vm/unit_test.h"
 #include "vm/profiler.h"
 #include "vm/thread_pool.h"
@@ skipping 115 matching lines @@
       }
       // Check that we can create handles and allocate in old space.
       String& str = String::Handle(zone, String::New("old", Heap::kOld));
       EXPECT(str.Equals("old"));
 
       const intptr_t unique_smi = id_ + 928327281;
       Smi& smi = Smi::Handle(zone, Smi::New(unique_smi));
       EXPECT(smi.Value() == unique_smi);
       ObjectCounter counter(isolate_, &smi);
       // Ensure that our particular zone is visited.
-      // TODO(koda): Remove "->thread_registry()" after updating stack walker.
-      isolate_->thread_registry()->VisitObjectPointers(&counter);
+      isolate_->IterateObjectPointers(&counter,
+                                      /* visit_prologue_weak_handles = */ true,
+                                      /* validate_frames = */ true);

[Ivan Posva, 2015/08/11 17:41:31]

ditto

       EXPECT_EQ(1, counter.count());
 
       char* unique_chars = zone->PrintToString("unique_str_%" Pd, id_);
       String& unique_str = String::Handle(zone);
       {
         // String::New may create additional handles in the topmost scope that
         // we don't want to count, so wrap this in its own scope.
         HANDLESCOPE(thread);
         unique_str = String::New(unique_chars, Heap::kOld);
       }
@@ skipping 284 matching lines @@
   while (true) {
     isolate->thread_registry()->CheckSafepoint();
     MutexLocker ml(&mutex);
     if (exited == SafepointTestTask::kTaskCount) {
       break;
     }
   }
 }
 
 }  // namespace dart