Updated Chrome Test pages

Updated Chrome Test pages to:
1. include Chrome Frame meta tag
2. use adapter.js

BUG=1198
TEST= Chrome Canary, FireFox Nightly and Internet Explorer

[elham1, 2013-03-14 20:06:12]

Hi Henrik,
Can you please review this

[kjellander_chromium, 2013-03-15 09:14:06]

Nice to get this done so the pages can also be used with Firefox. Needs some
additional work.

Please also add a TEST= entry in the description, and describe how you have
tested this (I assume one or more Chrome versions and Firefox Nightly?)

https://codereview.chromium.org/12824011/diff/1/adapter.js
File adapter.js (right):

https://codereview.chromium.org/12824011/diff/1/adapter.js#newcode1
adapter.js:1: var RTCPeerConnection = null;
Please do not add another copy of adapter.js here.

Refer to https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js when
you're including the script instead.

https://codereview.chromium.org/12824011/diff/1/getusermedia.js
File getusermedia.js (right):

https://codereview.chromium.org/12824011/diff/1/getusermedia.js#newcode55
getusermedia.js:55: getUserMediaOkCallback_,
Fix indentation.

https://codereview.chromium.org/12824011/diff/1/getusermedia.js#newcode61
getusermedia.js:61: * Must be called after calling doGetUserMedia. Returns
not-called-yet if we have
80 chars line limit.

https://codereview.chromium.org/12824011/diff/1/jsep01_call.js
File jsep01_call.js (right):

https://codereview.chromium.org/12824011/diff/1/jsep01_call.js#newcode220
jsep01_call.js:220: attachMediaStream(videoTag,event.stream);
space after ,

https://codereview.chromium.org/12824011/diff/1/manual/constraints.html
File manual/constraints.html (right):

https://codereview.chromium.org/12824011/diff/1/manual/constraints.html#newcode6
manual/constraints.html:6: <!-- Load the polyfill to switch-hit between Chrome
and Firefox -->
End comments with punctuation.

https://codereview.chromium.org/12824011/diff/1/manual/constraints.html#newcode7
manual/constraints.html:7: <script type="text/javascript"
src="../adapter.js"></script>
Refer to https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js
instead of this local file.

https://codereview.chromium.org/12824011/diff/1/manual/constraints.js
File manual/constraints.js (right):

https://codereview.chromium.org/12824011/diff/1/manual/constraints.js#newcode26
manual/constraints.js:26: getUserMediaOkCallback_,
Fix indentation.

https://codereview.chromium.org/12824011/diff/1/manual/peerconnection.html
File manual/peerconnection.html (right):

https://codereview.chromium.org/12824011/diff/1/manual/peerconnection.html#ne...
manual/peerconnection.html:6: <!-- Load the polyfill to switch-hit between
Chrome and Firefox -->
End comments with punctuation.

https://codereview.chromium.org/12824011/diff/1/manual/peerconnection.html#ne...
manual/peerconnection.html:7: <script type="text/javascript"
src="../adapter.js"></script>
Use https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js instead.

https://codereview.chromium.org/12824011/diff/1/webrtc_jsep01_test.html
File webrtc_jsep01_test.html (right):

https://codereview.chromium.org/12824011/diff/1/webrtc_jsep01_test.html#newcode6
webrtc_jsep01_test.html:6: <script type="text/javascript"
src="adapter.js"></script>
Use https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js instead.

https://codereview.chromium.org/12824011/diff/1/webrtc_video_quality_test.html
File webrtc_video_quality_test.html (right):

https://codereview.chromium.org/12824011/diff/1/webrtc_video_quality_test.htm...
webrtc_video_quality_test.html:6: <script type="text/javascript"
src="adapter.js"></script>
Use https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js

[kjellander_chromium, 2013-03-15 09:15:21]

On 2013/03/15 09:14:06, Henrik Kjellander wrote:
> Nice to get this done so the pages can also be used with Firefox. Needs some
> additional work.
> 
> Please also add a TEST= entry in the description, and describe how you have
> tested this (I assume one or more Chrome versions and Firefox Nightly?)
> 
> https://codereview.chromium.org/12824011/diff/1/adapter.js
> File adapter.js (right):
> 
> https://codereview.chromium.org/12824011/diff/1/adapter.js#newcode1
> adapter.js:1: var RTCPeerConnection = null;
> Please do not add another copy of adapter.js here.
> 
> Refer to https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js
when
> you're including the script instead.
> 
> https://codereview.chromium.org/12824011/diff/1/getusermedia.js
> File getusermedia.js (right):
> 
> https://codereview.chromium.org/12824011/diff/1/getusermedia.js#newcode55
> getusermedia.js:55: getUserMediaOkCallback_,
> Fix indentation.
> 
> https://codereview.chromium.org/12824011/diff/1/getusermedia.js#newcode61
> getusermedia.js:61: * Must be called after calling doGetUserMedia. Returns
> not-called-yet if we have
> 80 chars line limit.
> 
> https://codereview.chromium.org/12824011/diff/1/jsep01_call.js
> File jsep01_call.js (right):
> 
> https://codereview.chromium.org/12824011/diff/1/jsep01_call.js#newcode220
> jsep01_call.js:220: attachMediaStream(videoTag,event.stream);
> space after ,
> 
> https://codereview.chromium.org/12824011/diff/1/manual/constraints.html
> File manual/constraints.html (right):
> 
>
https://codereview.chromium.org/12824011/diff/1/manual/constraints.html#newcode6
> manual/constraints.html:6: <!-- Load the polyfill to switch-hit between Chrome
> and Firefox -->
> End comments with punctuation.
> 
>
https://codereview.chromium.org/12824011/diff/1/manual/constraints.html#newcode7
> manual/constraints.html:7: <script type="text/javascript"
> src="../adapter.js"></script>
> Refer to https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js
> instead of this local file.
> 
> https://codereview.chromium.org/12824011/diff/1/manual/constraints.js
> File manual/constraints.js (right):
> 
>
https://codereview.chromium.org/12824011/diff/1/manual/constraints.js#newcode26
> manual/constraints.js:26: getUserMediaOkCallback_,
> Fix indentation.
> 
> https://codereview.chromium.org/12824011/diff/1/manual/peerconnection.html
> File manual/peerconnection.html (right):
> 
>
https://codereview.chromium.org/12824011/diff/1/manual/peerconnection.html#ne...
> manual/peerconnection.html:6: <!-- Load the polyfill to switch-hit between
> Chrome and Firefox -->
> End comments with punctuation.
> 
>
https://codereview.chromium.org/12824011/diff/1/manual/peerconnection.html#ne...
> manual/peerconnection.html:7: <script type="text/javascript"
> src="../adapter.js"></script>
> Use https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js
instead.
> 
> https://codereview.chromium.org/12824011/diff/1/webrtc_jsep01_test.html
> File webrtc_jsep01_test.html (right):
> 
>
https://codereview.chromium.org/12824011/diff/1/webrtc_jsep01_test.html#newcode6
> webrtc_jsep01_test.html:6: <script type="text/javascript"
> src="adapter.js"></script>
> Use https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js
instead.
> 
> https://codereview.chromium.org/12824011/diff/1/webrtc_video_quality_test.html
> File webrtc_video_quality_test.html (right):
> 
>
https://codereview.chromium.org/12824011/diff/1/webrtc_video_quality_test.htm...
> webrtc_video_quality_test.html:6: <script type="text/javascript"
> src="adapter.js"></script>
> Use https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js

Also note that the first line of the description becomes the title of the CL.
Make it a short summary of the contents of the CL. 
After initial upload, you'll have to edit this manually however.

[elham1, 2013-03-21 22:36:27]

https://codereview.chromium.org/12824011/diff/1/adapter.js
File adapter.js (right):

https://codereview.chromium.org/12824011/diff/1/adapter.js#newcode1
adapter.js:1: var RTCPeerConnection = null;
On 2013/03/15 09:14:06, Henrik Kjellander wrote:
> Please do not add another copy of adapter.js here.
> 
> Refer to https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js
when
> you're including the script instead.

Done.

https://codereview.chromium.org/12824011/diff/1/getusermedia.js
File getusermedia.js (right):

https://codereview.chromium.org/12824011/diff/1/getusermedia.js#newcode55
getusermedia.js:55: getUserMediaOkCallback_,
On 2013/03/15 09:14:06, Henrik Kjellander wrote:
> Fix indentation.

Done.

https://codereview.chromium.org/12824011/diff/1/getusermedia.js#newcode61
getusermedia.js:61: * Must be called after calling doGetUserMedia. Returns
not-called-yet if we have
On 2013/03/15 09:14:06, Henrik Kjellander wrote:
> 80 chars line limit.

Done.

https://codereview.chromium.org/12824011/diff/1/jsep01_call.js
File jsep01_call.js (right):

https://codereview.chromium.org/12824011/diff/1/jsep01_call.js#newcode220
jsep01_call.js:220: attachMediaStream(videoTag,event.stream);
On 2013/03/15 09:14:06, Henrik Kjellander wrote:
> space after ,

Done.

https://codereview.chromium.org/12824011/diff/1/manual/constraints.html
File manual/constraints.html (right):

https://codereview.chromium.org/12824011/diff/1/manual/constraints.html#newcode7
manual/constraints.html:7: <script type="text/javascript"
src="../adapter.js"></script>
On 2013/03/15 09:14:06, Henrik Kjellander wrote:
> Refer to https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js
> instead of this local file.

Done.

https://codereview.chromium.org/12824011/diff/1/manual/peerconnection.html
File manual/peerconnection.html (right):

https://codereview.chromium.org/12824011/diff/1/manual/peerconnection.html#ne...
manual/peerconnection.html:7: <script type="text/javascript"
src="../adapter.js"></script>
On 2013/03/15 09:14:06, Henrik Kjellander wrote:
> Use https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js
instead.

Done.

https://codereview.chromium.org/12824011/diff/1/webrtc_jsep01_test.html
File webrtc_jsep01_test.html (right):

https://codereview.chromium.org/12824011/diff/1/webrtc_jsep01_test.html#newcode6
webrtc_jsep01_test.html:6: <script type="text/javascript"
src="adapter.js"></script>
On 2013/03/15 09:14:06, Henrik Kjellander wrote:
> Use https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js
instead.

Done.

https://codereview.chromium.org/12824011/diff/1/webrtc_video_quality_test.html
File webrtc_video_quality_test.html (right):

https://codereview.chromium.org/12824011/diff/1/webrtc_video_quality_test.htm...
webrtc_video_quality_test.html:6: <script type="text/javascript"
src="adapter.js"></script>
On 2013/03/15 09:14:06, Henrik Kjellander wrote:
> Use https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js

Done.

[phoglund_chromium, 2013-03-22 15:07:18]

Drive-by.

(Let me know when you have patched the automated tests. I can then download the
patch and try for you so you don't have to set up for running the automated
tests).

https://codereview.chromium.org/12824011/diff/19001/getusermedia.js
File getusermedia.js (right):

https://codereview.chromium.org/12824011/diff/19001/getusermedia.js#newcode41
getusermedia.js:41: */
This gets called from the browser tests and PyAuto tests, so you need to update
those too - otherwise all our automated tests will break. It's unfortunate that
this function happened to be called the same as in adapter.js. Fortunately the
code is well factorized so you only need to change in a handful of places.

So you'll need to change to doGetUserMedia in the following places:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/med...
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/functi...
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/functi...
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/functi...

https://codereview.chromium.org/12824011/diff/19001/getusermedia.js#newcode54
getusermedia.js:54: getUserMedia(evaluatedConstraints,
Nit: indentation

https://codereview.chromium.org/12824011/diff/19001/getusermedia.js#newcode61
getusermedia.js:61: * Must be called after calling doGetUserMedia. Returns
not-called-yet if we
Nit: lines should not end with whitespace. Configure your text editor to do this
for you.

https://codereview.chromium.org/12824011/diff/19001/getusermedia.js#newcode161
getusermedia.js:161: function getUserMediaFailedCallback_(error) {
Nit: line length

https://codereview.chromium.org/12824011/diff/19001/manual/constraints.html
File manual/constraints.html (right):

https://codereview.chromium.org/12824011/diff/19001/manual/constraints.html#n...
manual/constraints.html:6: <!-- Load the polyfill to switch-hit between Chrome
and Firefox -->
Nit: try to avoid line wrapping, for instance by moving down the src=.
<script type="text/javascript"
    src="...">
</script>

https://codereview.chromium.org/12824011/diff/19001/manual/constraints.js
File manual/constraints.js (right):

https://codereview.chromium.org/12824011/diff/19001/manual/constraints.js#new...
manual/constraints.js:25: getUserMedia(constraints,
Nit: indentation.

https://codereview.chromium.org/12824011/diff/19001/manual/constraints.js#new...
manual/constraints.js:108: attachMediaStream(videoTag, stream);
Nit: I wouldn't remove that blank line: it looks better with a blank line before
comments.

https://codereview.chromium.org/12824011/diff/19001/webrtc_jsep01_test.html
File webrtc_jsep01_test.html (right):

https://codereview.chromium.org/12824011/diff/19001/webrtc_jsep01_test.html#n...
webrtc_jsep01_test.html:5: <meta http-equiv="X-UA-Compatible"
content="chrome=1"/>
Nit: line length

https://codereview.chromium.org/12824011/diff/19001/webrtc_video_quality_test...
File webrtc_video_quality_test.html (right):

https://codereview.chromium.org/12824011/diff/19001/webrtc_video_quality_test...
webrtc_video_quality_test.html:5: <meta http-equiv="X-UA-Compatible"
content="chrome=1"/>
Nit: line length

[elham1, 2013-03-25 21:58:23]

https://codereview.chromium.org/12824011/diff/19001/getusermedia.js
File getusermedia.js (right):

https://codereview.chromium.org/12824011/diff/19001/getusermedia.js#newcode41
getusermedia.js:41: */
Okay, I will upload a seperate cl for that.
On 2013/03/22 15:07:18, phoglund wrote:
> This gets called from the browser tests and PyAuto tests, so you need to
update
> those too - otherwise all our automated tests will break. It's unfortunate
that
> this function happened to be called the same as in adapter.js. Fortunately the
> code is well factorized so you only need to change in a handful of places.
> 
> So you'll need to change to doGetUserMedia in the following places:
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/med...
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/functi...
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/functi...
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/functi...

https://codereview.chromium.org/12824011/diff/19001/getusermedia.js#newcode54
getusermedia.js:54: getUserMedia(evaluatedConstraints,
On 2013/03/22 15:07:18, phoglund wrote:
> Nit: indentation

Done.

https://codereview.chromium.org/12824011/diff/19001/getusermedia.js#newcode61
getusermedia.js:61: * Must be called after calling doGetUserMedia. Returns
not-called-yet if we
On 2013/03/22 15:07:18, phoglund wrote:
> Nit: lines should not end with whitespace. Configure your text editor to do
this
> for you.

Done.

https://codereview.chromium.org/12824011/diff/19001/getusermedia.js#newcode161
getusermedia.js:161: function getUserMediaFailedCallback_(error) {
On 2013/03/22 15:07:18, phoglund wrote:
> Nit: line length

Done.

https://codereview.chromium.org/12824011/diff/19001/manual/constraints.html
File manual/constraints.html (right):

https://codereview.chromium.org/12824011/diff/19001/manual/constraints.html#n...
manual/constraints.html:6: <!-- Load the polyfill to switch-hit between Chrome
and Firefox -->
On 2013/03/22 15:07:18, phoglund wrote:
> Nit: try to avoid line wrapping, for instance by moving down the src=.
> <script type="text/javascript"
>     src="...">
> </script>

Done.

https://codereview.chromium.org/12824011/diff/19001/manual/constraints.js
File manual/constraints.js (right):

https://codereview.chromium.org/12824011/diff/19001/manual/constraints.js#new...
manual/constraints.js:25: getUserMedia(constraints,
On 2013/03/22 15:07:18, phoglund wrote:
> Nit: indentation.

Done.

https://codereview.chromium.org/12824011/diff/19001/manual/constraints.js#new...
manual/constraints.js:108: attachMediaStream(videoTag, stream);
On 2013/03/22 15:07:18, phoglund wrote:
> Nit: I wouldn't remove that blank line: it looks better with a blank line
before
> comments.

Done.

https://codereview.chromium.org/12824011/diff/19001/webrtc_jsep01_test.html
File webrtc_jsep01_test.html (right):

https://codereview.chromium.org/12824011/diff/19001/webrtc_jsep01_test.html#n...
webrtc_jsep01_test.html:5: <meta http-equiv="X-UA-Compatible"
content="chrome=1"/>
On 2013/03/22 15:07:18, phoglund wrote:
> Nit: line length

Done.

https://codereview.chromium.org/12824011/diff/19001/webrtc_video_quality_test...
File webrtc_video_quality_test.html (right):

https://codereview.chromium.org/12824011/diff/19001/webrtc_video_quality_test...
webrtc_video_quality_test.html:5: <meta http-equiv="X-UA-Compatible"
content="chrome=1"/>
On 2013/03/22 15:07:18, phoglund wrote:
> Nit: line length

Done.

[kjellander_chromium, 2013-03-26 06:46:09]

The multiple style guides (JS, HTML and Chromium specific) is not easy to deal
with. Needs another adjustment but then we should be done. 
I added style guide links to my comments.

https://codereview.chromium.org/12824011/diff/19001/getusermedia.js
File getusermedia.js (right):

https://codereview.chromium.org/12824011/diff/19001/getusermedia.js#newcode41
getusermedia.js:41: */
I think it's better to include these changes in this CL, as it's the same
codebase. That way we'll avoid unnecessary test breakages.

On 2013/03/25 21:58:23, elham1 wrote:
> Okay, I will upload a seperate cl for that.
> On 2013/03/22 15:07:18, phoglund wrote:
> > This gets called from the browser tests and PyAuto tests, so you need to
> update
> > those too - otherwise all our automated tests will break. It's unfortunate
> that
> > this function happened to be called the same as in adapter.js. Fortunately
the
> > code is well factorized so you only need to change in a handful of places.
> > 
> > So you'll need to change to doGetUserMedia in the following places:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/med...
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/functi...
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/functi...
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/functi...
>

https://codereview.chromium.org/12824011/diff/30001/getusermedia.js
File getusermedia.js (right):

https://codereview.chromium.org/12824011/diff/30001/getusermedia.js#newcode55
getusermedia.js:55: getUserMediaFailedCallback_);
Indentation is still not correct here. It should either be aligned with the
left-parenthesis on the previous line or indented 4 spaces. See
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...

https://codereview.chromium.org/12824011/diff/30001/manual/constraints.html
File manual/constraints.html (right):

https://codereview.chromium.org/12824011/diff/30001/manual/constraints.html#n...
manual/constraints.html:8:
src="https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js">
I know the HTML style guide is tricky. A wrapped line shall be indented 4
spaces:
http://dev.chromium.org/developers/web-development-style-guide#TOC-Body

https://codereview.chromium.org/12824011/diff/30001/manual/constraints.js
File manual/constraints.js (right):

https://codereview.chromium.org/12824011/diff/30001/manual/constraints.js#new...
manual/constraints.js:26: getUserMediaFailedCallback_);
Same indentation fix needed here as in getusermedia.js

https://codereview.chromium.org/12824011/diff/30001/webrtc_jsep01_test.html
File webrtc_jsep01_test.html (right):

https://codereview.chromium.org/12824011/diff/30001/webrtc_jsep01_test.html#n...
webrtc_jsep01_test.html:7:
src="https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js">
+2 spaces indent.
http://dev.chromium.org/developers/web-development-style-guide#TOC-Body

https://codereview.chromium.org/12824011/diff/30001/webrtc_video_quality_test...
File webrtc_video_quality_test.html (right):

https://codereview.chromium.org/12824011/diff/30001/webrtc_video_quality_test...
webrtc_video_quality_test.html:6: <script type="text/javascript"
src="https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js"></script>
Still needs wrapping.

[phoglund_chromium, 2013-03-26 14:43:10]

> Okay, I will upload a seperate cl for that.
Hm. In that case you need to make sure to commit both at the same time or at
least very, very close to each other, otherwise the automated tests will break.

[elham, 2013-04-02 22:06:21]

https://codereview.chromium.org/12824011/diff/30001/getusermedia.js
File getusermedia.js (right):

https://codereview.chromium.org/12824011/diff/30001/getusermedia.js#newcode55
getusermedia.js:55: getUserMediaFailedCallback_);
On 2013/03/26 06:46:10, Henrik Kjellander wrote:
> Indentation is still not correct here. It should either be aligned with the
> left-parenthesis on the previous line or indented 4 spaces. See
>
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...

Done.

https://codereview.chromium.org/12824011/diff/30001/manual/constraints.html
File manual/constraints.html (right):

https://codereview.chromium.org/12824011/diff/30001/manual/constraints.html#n...
manual/constraints.html:8:
src="https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js">
On 2013/03/26 06:46:10, Henrik Kjellander wrote:
> I know the HTML style guide is tricky. A wrapped line shall be indented 4
> spaces:
> http://dev.chromium.org/developers/web-development-style-guide#TOC-Body

Done.

https://codereview.chromium.org/12824011/diff/30001/webrtc_jsep01_test.html
File webrtc_jsep01_test.html (right):

https://codereview.chromium.org/12824011/diff/30001/webrtc_jsep01_test.html#n...
webrtc_jsep01_test.html:7:
src="https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js">
On 2013/03/26 06:46:10, Henrik Kjellander wrote:
> +2 spaces indent.
> http://dev.chromium.org/developers/web-development-style-guide#TOC-Body

Done.

https://codereview.chromium.org/12824011/diff/30001/webrtc_video_quality_test...
File webrtc_video_quality_test.html (right):

https://codereview.chromium.org/12824011/diff/30001/webrtc_video_quality_test...
webrtc_video_quality_test.html:6: <script type="text/javascript"
src="https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js"></script>
On 2013/03/26 06:46:10, Henrik Kjellander wrote:
> Still needs wrapping.

Done.

[kjellander_chromium, 2013-04-03 09:09:51]

LGTM assuming the last nits are fixed.

I'm a bit confused about the Base URL saying
https://src.chromium.org/svn/trunk/src/chrome/test/data/webrtc/ now that your
latest patch set includes some of that path. 
I guess it's because when you started the CL, only files in
src/chrome/test/data/webrtc/ were changed.
Make sure to check in the source tree that it gets committed properly so not new
files are added in new folders below src/chrome/test/data/webrtc/

https://codereview.chromium.org/12824011/diff/62001/test/data/webrtc/getuserm...
File test/data/webrtc/getusermedia.js (right):

https://codereview.chromium.org/12824011/diff/62001/test/data/webrtc/getuserm...
test/data/webrtc/getusermedia.js:55: getUserMediaFailedCallback_);
I'm sorry if I confused you a little in the previous comment about the
indentation, but the 4-space indent is only intended for when the function
arguments are located one per line). 
See
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...

I would indent getUserMediaFailedCallback_ according to the parenthesis on the
previous line, but I'm not 100% sure so I can let this one slip.

https://codereview.chromium.org/12824011/diff/62001/test/data/webrtc/manual/p...
File test/data/webrtc/manual/peerconnection.html (right):

https://codereview.chromium.org/12824011/diff/62001/test/data/webrtc/manual/p...
test/data/webrtc/manual/peerconnection.html:7: <script itype="text/javascript"
src="https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js"></script>
Wrap properly.

https://codereview.chromium.org/12824011/diff/62001/test/data/webrtc/webrtc_v...
File test/data/webrtc/webrtc_video_quality_test.html (right):

https://codereview.chromium.org/12824011/diff/62001/test/data/webrtc/webrtc_v...
test/data/webrtc/webrtc_video_quality_test.html:5: <meta
http-equiv="X-UA-Compatible" content="chrome=1"/>
-2 spaces indent for the meta tag.

[elham, 2013-04-08 19:19:18]

https://codereview.chromium.org/12824011/diff/62001/test/data/webrtc/getuserm...
File test/data/webrtc/getusermedia.js (right):

https://codereview.chromium.org/12824011/diff/62001/test/data/webrtc/getuserm...
test/data/webrtc/getusermedia.js:55: getUserMediaFailedCallback_);
On 2013/04/03 09:09:51, Henrik Kjellander wrote:
> I'm sorry if I confused you a little in the previous comment about the
> indentation, but the 4-space indent is only intended for when the function
> arguments are located one per line). 
> See
>
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...
> 
> I would indent getUserMediaFailedCallback_ according to the parenthesis on the
> previous line, but I'm not 100% sure so I can let this one slip.

Done.

https://codereview.chromium.org/12824011/diff/62001/test/data/webrtc/manual/p...
File test/data/webrtc/manual/peerconnection.html (right):

https://codereview.chromium.org/12824011/diff/62001/test/data/webrtc/manual/p...
test/data/webrtc/manual/peerconnection.html:7: <script itype="text/javascript"
src="https://webrtc.googlecode.com/svn/trunk/samples/js/base/adapter.js"></script>
On 2013/04/03 09:09:51, Henrik Kjellander wrote:
> Wrap properly.

Done.

https://codereview.chromium.org/12824011/diff/62001/test/data/webrtc/webrtc_v...
File test/data/webrtc/webrtc_video_quality_test.html (right):

https://codereview.chromium.org/12824011/diff/62001/test/data/webrtc/webrtc_v...
test/data/webrtc/webrtc_video_quality_test.html:5: <meta
http-equiv="X-UA-Compatible" content="chrome=1"/>
On 2013/04/03 09:09:51, Henrik Kjellander wrote:
> -2 spaces indent for the meta tag.

Done.

[elham, 2013-04-08 19:42:45]

Adding Owners of chrome/browser/media and chrome/test/functional.

[no longer working on chromium, 2013-04-08 19:56:14]

On 2013/04/08 19:42:45, elham wrote:
> Adding Owners of chrome/browser/media and chrome/test/functional.

lgtm on chrome_webrtc_browsertest.cc

[dennis_jeffrey, 2013-04-08 19:59:39]

On 2013/04/08 19:56:14, xians1 wrote:
> On 2013/04/08 19:42:45, elham wrote:
> > Adding Owners of chrome/browser/media and chrome/test/functional.
> 
> lgtm on chrome_webrtc_browsertest.cc

chrome/test/functional LGTM

[commit-bot: I haz the power, 2013-04-08 21:14:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/elham@google.com/12824011/74002

[commit-bot: I haz the power, 2013-04-08 21:14:18]

Failed to apply patch for
chrome/test/data/webrtc/browser/media/chrome_webrtc_browsertest.cc:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  A         chrome/test/data/webrtc/browser
  Created missing directory chrome/test/data/webrtc/browser.
  A         chrome/test/data/webrtc/browser/media
  Created missing directory chrome/test/data/webrtc/browser/media.
  patching file
chrome/test/data/webrtc/browser/media/chrome_webrtc_browsertest.cc
  Hunk #1 FAILED at 101.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/test/data/webrtc/browser/media/chrome_webrtc_browsertest.cc.rej

Patch:       chrome/test/data/webrtc/browser/media/chrome_webrtc_browsertest.cc
Index: browser/media/chrome_webrtc_browsertest.cc
===================================================================
--- chrome/test/data/webrtc/browser/media/chrome_webrtc_browsertest.cc	(revision
191906)
+++ chrome/test/data/webrtc/browser/media/chrome_webrtc_browsertest.cc	(working
copy)
@@ -101,7 +101,7 @@
 
     // Request user media: this will launch the media stream info bar.
     EXPECT_EQ("ok-requested", ExecuteJavascript(
-        "getUserMedia('{video: true, audio: true}');", tab_contents));
+        "doGetUserMedia('{video: true, audio: true}');", tab_contents));
 
     // Wait for the bar to pop up, then accept.
     infobar_added.Wait();

[commit-bot: I haz the power, 2013-04-08 21:15:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/elham@google.com/12824011/74002

[commit-bot: I haz the power, 2013-04-08 21:15:17]

Failed to apply patch for
chrome/test/data/webrtc/browser/media/chrome_webrtc_browsertest.cc:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  A         chrome/test/data/webrtc/browser
  Created missing directory chrome/test/data/webrtc/browser.
  A         chrome/test/data/webrtc/browser/media
  Created missing directory chrome/test/data/webrtc/browser/media.
  patching file
chrome/test/data/webrtc/browser/media/chrome_webrtc_browsertest.cc
  Hunk #1 FAILED at 101.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/test/data/webrtc/browser/media/chrome_webrtc_browsertest.cc.rej

Patch:       chrome/test/data/webrtc/browser/media/chrome_webrtc_browsertest.cc
Index: browser/media/chrome_webrtc_browsertest.cc
===================================================================
--- chrome/test/data/webrtc/browser/media/chrome_webrtc_browsertest.cc	(revision
191906)
+++ chrome/test/data/webrtc/browser/media/chrome_webrtc_browsertest.cc	(working
copy)
@@ -101,7 +101,7 @@
 
     // Request user media: this will launch the media stream info bar.
     EXPECT_EQ("ok-requested", ExecuteJavascript(
-        "getUserMedia('{video: true, audio: true}');", tab_contents));
+        "doGetUserMedia('{video: true, audio: true}');", tab_contents));
 
     // Wait for the bar to pop up, then accept.
     infobar_added.Wait();

[phoglund_chromium, 2013-04-09 08:08:16]

lgtm. You need to rebase the patch and resolve any conflicts. I had one small
nit as well if you'd like to fix that.

https://codereview.chromium.org/12824011/diff/74002/test/data/webrtc/manual/c...
File test/data/webrtc/manual/constraints.js (right):

https://codereview.chromium.org/12824011/diff/74002/test/data/webrtc/manual/c...
test/data/webrtc/manual/constraints.js:25: getUserMedia(constraints,
getUserMediaOkCallback_,
Nit: indent

[phoglund_chromium, 2013-05-24 15:09:53]

What happened with this one? Did it fall between the cracks?...