Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1282393002: Pass "client_id" param to the enrollment frame. (Closed)

Created:
5 years, 4 months ago by dzhioev (left Google)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass "client_id" param to the enrollment frame. A "client_id" param passed to GAIA should match a "client_id" that is used for token exchange afterwards, otherwise token exchange doesn't work. If the param is not specified, GAIA uses default value, which is the same as official Google Chrome's "client_id". We didn't provide "client_id" for enrollment frame, as a result enrollment only worked in official builds. BUG=495527 TEST=browser_tests Committed: https://crrev.com/54308302f2fe310fc34c14b01060d1561d3b5548 Cr-Commit-Position: refs/heads/master@{#342871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M google_apis/gaia/fake_gaia.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dzhioev (left Google)
Hello, PTAL
5 years, 4 months ago (2015-08-11 02:23:11 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
5 years, 4 months ago (2015-08-11 14:43:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282393002/1
5 years, 4 months ago (2015-08-11 18:26:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 19:31:46 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 19:32:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54308302f2fe310fc34c14b01060d1561d3b5548
Cr-Commit-Position: refs/heads/master@{#342871}

Powered by Google App Engine
This is Rietveld 408576698