Convert remaining StringToLowerASCII to ToLowerASCII

Convert remaining StringToLowerASCII to ToLowerASCII.

Remove StringToLowerASCII. This removes the template and makes a consistent call that can take a string piece.

http_response_headers.cc in HttpResponseHeaders::RemoveHeaderLine there seemed to be a bug where it did
  std::string old_header_name_lowercase(name);
where it actually meant
  std::string old_header_name_lowercase(old_header_name);
I fixed this.

There were a number of cases where url.host() or url.scheme() was passed to ToLowerASCII. These are already guaranteed lower-case, so I removed the call.

There were a number of cases in net that did return ToLowerASCII().c_str() when the return type is a std::string, which is unnecessary and wasteful. I removed the c_str() call.

NOPRESUBMIT=true
(for touching code with wstrings)

Committed: https://crrev.com/8e2106dd88a61950569f9cfa8a94ad436d858658
Cr-Commit-Position: refs/heads/master@{#342869}

[brettw, 2015-08-10 22:46:00]

brettw@chromium.org changed reviewers:
+ rsleevi@chromium.org, yzshen@chromium.org

[brettw, 2015-08-10 22:46:01]

[Low priority]

Ryan: please look at net\http\http_response_headers.cc (and any other parts of
net you care about, but these are super simple).

Yuzhu: please look at the rest. The files with non-trivial search-and-replaces
are:

content/browser/accessibility/browser_accessibility_win.cc
content/child/npapi/plugin_host.cc
content\common\plugin_list.cc
content/shell/browser/shell_content_browser_client.cc
extensions/common/csp_validator.cc
extensions\browser\api\web_request\web_request_api_helpers.cc
extensions/browser/extension_throttle_manager.cc
extensions/common/csp_validator.cc
extensions/common/message_bundle.cc
net\base\data_url.cc
net\base\sdch_manager.cc
net\cookies\cookie_constants.cc
net\http\http_auto_multi_round_parse.cc
net\http\http_response_headers.cc !!
net\proxy\proxy_bypass_rules.cc
net\url_request\url_request_backoff_manager.cc
net\url_request\url_request_throttler_manager.cc
ppapi\proxy\file_chooser_resource.cc
sql\statement.cc
ui\chromeos\network\network_connect.cc
ui\gl\gl_version_info.cc

[brettw, 2015-08-10 22:46:11]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-10 22:46:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282363003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282363003/20001

[Ryan Sleevi, 2015-08-10 22:55:00]

I only saw three cases of the .c_str() example, so maybe I missed something.

re: scheme/host being lowercase, that's true for GURL (since they should have
been canonicalized), but not necessarily true if someone isn't canonicalizing.
However, all your changes should be working on canonicalized input, so that's
fine

//net LGTM

[commit-bot: I haz the power, 2015-08-10 22:57:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-10 22:57:03]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-08-10 23:13:01]

On 2015/08/10 22:55:00, Ryan Sleevi wrote:
> I only saw three cases of the .c_str() example, so maybe I missed something.
> 
> re: scheme/host being lowercase, that's true for GURL (since they should have
> been canonicalized), but not necessarily true if someone isn't canonicalizing.
> However, all your changes should be working on canonicalized input, so that's
> fine

Yes, I changed only the ones where the result came directly out of a GURL, since
that's guaranteed. I suspect a lot of the other cases can be fixed as well where
"domain" strings are passed around, but the guarantees around these are not very
clear so I dare not touch them.

[brettw, 2015-08-10 23:45:55]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-10 23:46:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282363003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282363003/20001

[commit-bot: I haz the power, 2015-08-10 23:50:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-10 23:50:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2015-08-11 16:36:03]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 16:36:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282363003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282363003/20001

[commit-bot: I haz the power, 2015-08-11 16:41:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 16:41:22]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2015-08-11 16:49:27]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 16:49:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282363003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282363003/40001

[yzshen1, 2015-08-11 18:05:50]

LGTM

I only looked at those files that you mentioned in the description. Thanks for
the detailed description!

[brettw, 2015-08-11 18:09:10]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2015-08-11 18:09:13]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-08-11 18:09:14]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/1282363003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-08-11 18:10:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282363003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282363003/40001

[commit-bot: I haz the power, 2015-08-11 19:30:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-11 19:31:43]

Patchset 3 (id:??) landed as
https://crrev.com/8e2106dd88a61950569f9cfa8a94ad436d858658
Cr-Commit-Position: refs/heads/master@{#342869}