Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 1282353002: Prepare height calculation methods in LayoutFlowThread for nested multicol. (Closed)

Created:
5 years, 4 months ago by mstensho (USE GERRIT)
Modified:
5 years, 4 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Prepare height calculation methods in LayoutFlowThread for nested multicol. Rename pageLogicalHeight() in LayoutMultiColumnSet to pageLogicalHeightForOffset(), so that it matches the naming of pageRemainingLogicalHeightForOffset(). Move the innards to LayoutMultiColumnSet. And some 0 -> LayoutUnit() cleanup. Had to adjust some call sites because of this and introduce isPageLogicalHeightKnown(). No behavioral changes intended for now. R=jchaffraix@chromium.org,leviw@chromium.org BUG=447718 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -21 lines) Patch
M Source/core/layout/LayoutFlowThread.cpp View 1 chunk +5 lines, -14 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutMultiColumnSet.h View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/layout/LayoutMultiColumnSet.cpp View 1 chunk +22 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutPagedFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/MultiColumnFragmentainerGroup.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
leviw_travelin_and_unemployed
lgtm Simple enough to review :)
5 years, 4 months ago (2015-08-10 20:37:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282353002/1
5 years, 4 months ago (2015-08-10 20:37:50 UTC) #3
mstensho (USE GERRIT)
Whoa! It got reviewed even before I published it. FWIW, no worries. It was ready ...
5 years, 4 months ago (2015-08-10 20:44:17 UTC) #4
leviw_travelin_and_unemployed
On 2015/08/10 at 20:44:17, mstensho wrote: > Whoa! It got reviewed even before I published ...
5 years, 4 months ago (2015-08-10 21:32:38 UTC) #5
leviw_travelin_and_unemployed
On 2015/08/10 at 21:32:38, leviw wrote: > On 2015/08/10 at 20:44:17, mstensho wrote: > > ...
5 years, 4 months ago (2015-08-10 21:33:08 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 22:50:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200272

Powered by Google App Engine
This is Rietveld 408576698