Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 128233002: Add Isolate parameter to HandleScope::NumberOfHandles. (Closed)

Created:
6 years, 11 months ago by Sven Panne
Modified:
6 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add Isolate parameter to HandleScope::NumberOfHandles. LOG=y BUG=324225 R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -26 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +18 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 11 months ago (2014-01-08 13:11:38 UTC) #1
Michael Starzinger
LGTM.
6 years, 11 months ago (2014-01-09 10:04:04 UTC) #2
Sven Panne
6 years, 11 months ago (2014-01-09 10:37:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18510 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698