PageLoadMetrics renderer and browser implementation (deprecated)

chrome/renderer/chrome_content_renderer_client.cc

Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 5bc5267dedd73d7315aba3a4dfe7d93bb1463b8e..b8b9ad346e23fa83f06c0846e562918575c74232 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -63,6 +63,7 @@
 #include "components/nacl/renderer/ppb_nacl_private.h"
 #include "components/nacl/renderer/ppb_nacl_private_impl.h"
 #include "components/network_hints/renderer/prescient_networking_dispatcher.h"
+#include "components/page_load_metrics/renderer/page_load_metrics_render_frame_observer.h"
 #include "components/password_manager/content/renderer/credential_manager_client.h"
 #include "components/pdf/renderer/pepper_pdf_host.h"
 #include "components/plugins/renderer/mobile_youtube_plugin.h"
@@ -582,6 +583,15 @@ void ChromeContentRendererClient::RenderFrameCreated(
     new NetErrorHelper(render_frame);
   }
 
+#if defined(OS_ANDROID)
+  // TODO(bmcquade): run on all platforms once crbug.com/521010 is resolved.
+  if (render_frame->GetRenderView()->GetMainRenderFrame() == render_frame) {

[nasko, 2015/08/20 00:22:18]

The code as you have it will break very soon. You can use
render_frame->GetWebFrame()->parent() and check for nullptr, since a frame
without a parent is the main one.

I'll spin a separate discussion whether RenderFrame::IsMainFrame should be added
to help such checks.

[Bryan McQuade, 2015/08/25 13:53:36]

Done, thanks!

+    // Only attach PageLoadMetricsRenderFrameObserver to the main frame, since
+    // we only want to log page load metrics for the main frame.
+    new page_load_metrics::PageLoadMetricsRenderFrameObserver(render_frame);
+  }
+#endif
+
   PasswordAutofillAgent* password_autofill_agent =
       new PasswordAutofillAgent(render_frame);
   PasswordGenerationAgent* password_generation_agent =