Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6152)

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 1282303002: PageLoadMetrics renderer and browser implementation (deprecated) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_helpers.cc
diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc
index 2d57807233f91653685ed618774de929aa4b0560..74af40a27395f90a7a6637bfb265f307f5c241c9 100644
--- a/chrome/browser/ui/tab_helpers.cc
+++ b/chrome/browser/ui/tab_helpers.cc
@@ -53,6 +53,7 @@
#include "chrome/browser/android/webapps/single_tab_mode_tab_helper.h"
#include "chrome/browser/ui/android/context_menu_helper.h"
#include "chrome/browser/ui/android/window_android_helper.h"
+#include "components/page_load_metrics/browser/page_load_metrics_web_contents_observer.h"
#else
#include "chrome/browser/banners/app_banner_manager_desktop.h"
#include "chrome/browser/plugins/plugin_observer.h"
@@ -181,6 +182,10 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {
SingleTabModeTabHelper::CreateForWebContents(web_contents);
VoiceSearchTabHelper::CreateForWebContents(web_contents);
WindowAndroidHelper::CreateForWebContents(web_contents);
+
+ // TODO(bmcquade): run on all platforms once crbug.com/521010 is resolved.
Randy Smith (Not in Mondays) 2015/08/17 19:31:07 I'm not sure which way I feel is better architectu
Bryan McQuade 2015/08/25 13:53:35 Turns out we can address this issue in the browser
+ page_load_metrics::PageLoadMetricsWebContentsObserver::CreateForWebContents(
+ web_contents);
#else
extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(
web_contents);

Powered by Google App Engine
This is Rietveld 408576698