components/page_load_metrics/common/page_load_metrics_messages.h - Issue 1282303002: PageLoadMetrics renderer and browser implementation (deprecated)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/page_load_metrics/common/page_load_metrics_messages.h

Issue 1282303002: PageLoadMetrics renderer and browser implementation (deprecated) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/page_load_metrics/browser/page_load_metrics_web_contents_observer.cc ('K') | « components/page_load_metrics/common/BUILD.gn ('k') | components/page_load_metrics/common/page_load_metrics_messages.cc » ('j') | components/page_load_metrics/renderer/page_load_metrics_render_frame_observer.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.
	davidben 2015/08/18 21:39:45 Since this is adding IPCs and such, it'll need IPC Since this is adding IPCs and such, it'll need IPC review and I think .../common/OWNERS needs to have the standard "per-file _messages.h blah" lines.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // IPC messages for extensions.
	davidben 2015/08/18 21:39:45 extensions -> something else? extensions -> something else? Bryan McQuade 2015/08/25 13:53:35 Done. Show quoted text On 2015/08/18 21:39:45, David Benjamin (slow) wrote: > extensions -> something else? Done.
	6 // Multiply-included message file, hence no include guard.

	7

	8 #include "base/time/time.h"

	9 #include "ipc/ipc_message_macros.h"

	10

	11 #define IPC_MESSAGE_START PageLoadMetricsMsgStart

	12

	13 IPC_MESSAGE_ROUTED1(PageLoadMetricsMsg_DOMContentLoadedEvent, base::TimeDelta)
	davidben 2015/08/18 21:39:45 Documentation? Documentation? Bryan McQuade 2015/08/25 13:53:35 Done. Show quoted text On 2015/08/18 21:39:45, David Benjamin wrote: > Documentation? Done.
	14 IPC_MESSAGE_ROUTED1(PageLoadMetricsMsg_LoadEvent, base::TimeDelta)

	15 IPC_MESSAGE_ROUTED1(PageLoadMetricsMsg_FirstLayout, base::TimeDelta)

OLD	NEW