Issue 12823002: Merge 186166 "Improved CoreAudioUtil::IsSupported()."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12823002: Merge 186166 "Improved CoreAudioUtil::IsSupported()." (Closed)

Created:
7 years, 9 months ago by henrika (OOO until Aug 14)

Modified:
7 years, 9 months ago

Reviewers:
henrika (OOO until Aug 14)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1410/src/

Visibility:
Public.

More Reviews

Description

Merge 186166 "Improved CoreAudioUtil::IsSupported()." > Improved CoreAudioUtil::IsSupported(). > > This patch adds one more test in CoreAudioUtil::IsSupported() and that is to be able to create an IMMDeviceEnumerator. We have seen some crashes where it does not seem to be sufficient to check that Audioses.dll can be loaded. I hope we are fine now. > > BUG=166397 > TEST=media_unittests and different audio clients in Chrome. > > Review URL: https://chromiumcodereview.appspot.com/12378066 TBR=henrika@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187811

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -4 lines)			Patch
	M	media/audio/win/core_audio_util_win.cc	View		3 chunks	+29 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

henrika (OOO until Aug 14)

7 years, 9 months ago (2013-03-13 08:13:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r187811.

Expand Messages | Collapse Messages