Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1282223003: bindings: Adds a layout test to check Window's name look-up behavior. (Closed)

Created:
5 years, 4 months ago by Yuki
Modified:
5 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

bindings: Adds a layout test to check Window's name look-up behavior. Adds a layout test to showcase expected results of name look-up of Window's members. The planned bahavioral change will fix these test cases. The expected output of the test is: ---------------- This is a testharness.js-based test. PASS Named access test. Window's members should have priority over named properties. PASS WindowProperties object should exist. PASS WindowProperties object should provide named access. PASS Window's members should be own members. Harness: the test ran to completion. ---------------- (copied from test results on Firefox.) BUG=516274 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200382

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
A LayoutTests/fast/dom/Window/lookup-behavior.html View 1 1 chunk +52 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Window/lookup-behavior-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yuki
Could you review this CL?
5 years, 4 months ago (2015-08-11 06:58:42 UTC) #2
haraken
I'm just curious but what's the behavior of Safari and IE? https://codereview.chromium.org/1282223003/diff/1/LayoutTests/fast/dom/Window/lookup-behavior.html File LayoutTests/fast/dom/Window/lookup-behavior.html (right): ...
5 years, 4 months ago (2015-08-11 07:00:52 UTC) #3
Yuki
IE and Safari - don't support WindowProperties object. - place some of members on Window.prototype ...
5 years, 4 months ago (2015-08-12 04:51:49 UTC) #4
haraken
On 2015/08/12 04:51:49, Yuki wrote: > IE and Safari > - don't support WindowProperties object. ...
5 years, 4 months ago (2015-08-12 05:00:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282223003/20001
5 years, 4 months ago (2015-08-12 05:21:54 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 06:05:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200382

Powered by Google App Engine
This is Rietveld 408576698