Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/objects.cc

Issue 12822002: remove maynamedaccess checks (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/isolate.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 750 matching lines...) Expand 10 before | Expand all | Expand 10 after
761 : Object::cast(heap->null_value()); 761 : Object::cast(heap->null_value());
762 ASSERT(this != this->GetPrototype(isolate)); 762 ASSERT(this != this->GetPrototype(isolate));
763 for (Object* current = this; 763 for (Object* current = this;
764 true; 764 true;
765 current = current->GetPrototype(isolate)) { 765 current = current->GetPrototype(isolate)) {
766 if (current->IsAccessCheckNeeded()) { 766 if (current->IsAccessCheckNeeded()) {
767 // Check if we're allowed to read from the current object. Note 767 // Check if we're allowed to read from the current object. Note
768 // that even though we may not actually end up loading the named 768 // that even though we may not actually end up loading the named
769 // property from the current object, we still check that we have 769 // property from the current object, we still check that we have
770 // access to it. 770 // access to it.
771 // TODO(dcarney): revert.
772 CHECK(current->IsJSObject());
773 JSObject* checked = JSObject::cast(current); 771 JSObject* checked = JSObject::cast(current);
774 if (!heap->isolate()->MayNamedAccess(checked, name, v8::ACCESS_GET)) { 772 if (!heap->isolate()->MayNamedAccess(checked, name, v8::ACCESS_GET)) {
775 return checked->GetPropertyWithFailedAccessCheck(receiver, 773 return checked->GetPropertyWithFailedAccessCheck(receiver,
776 result, 774 result,
777 name, 775 name,
778 attributes); 776 attributes);
779 } 777 }
780 } 778 }
781 // Stop traversing the chain once we reach the last object in the 779 // Stop traversing the chain once we reach the last object in the
782 // chain; either the holder of the result or null in case of an 780 // chain; either the holder of the result or null in case of an
(...skipping 13542 matching lines...) Expand 10 before | Expand all | Expand 10 after
14325 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER); 14323 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
14326 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER); 14324 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
14327 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER); 14325 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
14328 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER); 14326 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
14329 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER); 14327 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
14330 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER); 14328 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
14331 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER); 14329 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
14332 } 14330 }
14333 14331
14334 } } // namespace v8::internal 14332 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/isolate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698