Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1282143002: Remove an unused function. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/ports/SkFontHost_win.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
5 years, 4 months ago (2015-08-09 03:11:21 UTC) #2
mtklein
lgtm Is that all for ska + third_party/skia?
5 years, 4 months ago (2015-08-10 12:57:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282143002/1
5 years, 4 months ago (2015-08-10 12:57:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/c5b7df48b212fbabcc5df87b18376818bd91c1c2
5 years, 4 months ago (2015-08-10 13:05:22 UTC) #7
Nico
5 years, 4 months ago (2015-08-10 15:33:11 UTC) #8
Message was sent while issue was closed. 
On 2015/08/10 12:57:16, mtklein wrote:
> lgtm
> 
> Is that all for ska + third_party/skia?

Yes. (I think we might already build with that flag on non-Windows.)

Powered by Google App Engine
This is Rietveld 408576698