Split function block scoping into a separate flag

Split function block scoping into a separate flag

In an initial attempt to implement sloppy mode lexical bindings,
functions were made lexically scoped in sloppy mode. However, the
ES2015 spec says that they need an additional hoisted var binding,
and further, it's not clear when we'll implement that behavior
or whether it's web-compatible.

This patch splits off function block scoping into a new, separate
flag called --harmony_sloppy_function. This change will enable the
possibility of testing and shipping this feature separately from
other block scoping-related features which don't have the same risks.

BUG=v8:4285
R=adamk
LOG=N

Committed: https://crrev.com/1ebf0d7c5d86853ccb5c97c7b4486d644f0e0334
Cr-Commit-Position: refs/heads/master@{#30122}

[Dan Ehrenberg, 2015-08-07 23:48:01]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-07 23:48:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282093002/1

[commit-bot: I haz the power, 2015-08-08 00:00:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-08 00:00:12]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8499)

[Dan Ehrenberg, 2015-08-08 00:05:35]

On 2015/08/08 00:00:12, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   v8_mac_rel on tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8499)

I should've waited for the tests to finish before mailing... I guess we don't
want to just delete those tests. What do we want to do with v8:4285? Should this
be split into a separate flag in favor of eventually fixing v8:4285? I'm
wondering if we could ship other lexical scoping things without this part.

[adamk, 2015-08-08 01:13:31]

I like the idea of further-splitting the scoping options, putting the ES2015
semantics for function scoping behind their own flag (at least for the purposes
of facilitating development). I don't think we're ready to give up on
implementing the Appendix B behavior, though.

[Dan Ehrenberg, 2015-08-11 00:54:38]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 00:54:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282093002/1

[Dan Ehrenberg, 2015-08-11 00:54:53]

The CQ bit was unchecked by littledan@chromium.org

[Dan Ehrenberg, 2015-08-11 01:03:51]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 01:04:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282093002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282093002/20001

[commit-bot: I haz the power, 2015-08-11 01:14:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 01:14:38]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8544)

[Dan Ehrenberg, 2015-08-11 01:18:15]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 01:18:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282093002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282093002/40001

[commit-bot: I haz the power, 2015-08-11 01:26:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 01:26:45]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8545)

[Dan Ehrenberg, 2015-08-11 18:29:37]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 18:29:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282093002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282093002/40001

[commit-bot: I haz the power, 2015-08-11 18:41:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 18:41:37]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8574)

[Dan Ehrenberg, 2015-08-11 21:12:18]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 21:12:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282093002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282093002/60001

[commit-bot: I haz the power, 2015-08-11 21:37:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 21:37:55]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2015-08-11 21:40:25]

PTAL

[adamk, 2015-08-11 21:50:11]

https://codereview.chromium.org/1282093002/diff/60001/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/1282093002/diff/60001/src/flag-definitions.h#...
src/flag-definitions.h:191: V(harmony_block_function, "harmony function block
scoping")   \
How about "harmony_sloppy_function" instead? We already block-scope functions in
strict mode (it also puts it next to the analogous "harmony_sloppy_let").

[Dan Ehrenberg, 2015-08-11 21:57:20]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 21:57:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282093002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282093002/80001

[commit-bot: I haz the power, 2015-08-11 22:04:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 22:04:49]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Dan Ehrenberg, 2015-08-11 22:48:25]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 22:48:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282093002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282093002/100001

[commit-bot: I haz the power, 2015-08-11 22:49:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 22:49:29]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/8480)
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/7532)

[Dan Ehrenberg, 2015-08-11 22:53:46]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 22:53:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282093002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282093002/120001

[commit-bot: I haz the power, 2015-08-11 23:30:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 23:30:11]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2015-08-11 23:55:16]

https://codereview.chromium.org/1282093002/diff/60001/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/1282093002/diff/60001/src/flag-definitions.h#...
src/flag-definitions.h:191: V(harmony_block_function, "harmony function block
scoping")   \
On 2015/08/11 at 21:50:11, adamk wrote:
> How about "harmony_sloppy_function" instead? We already block-scope functions
in strict mode (it also puts it next to the analogous "harmony_sloppy_let").

Renamed the flag, what do you think?

[adamk, 2015-08-11 23:56:00]

lgtm, thanks

[Dan Ehrenberg, 2015-08-11 23:56:48]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2015-08-11 23:56:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282093002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282093002/120001

[commit-bot: I haz the power, 2015-08-11 23:59:53]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-08-12 00:00:13]

Patchset 7 (id:??) landed as
https://crrev.com/1ebf0d7c5d86853ccb5c97c7b4486d644f0e0334
Cr-Commit-Position: refs/heads/master@{#30122}