Add support for H264 and VP9 to AndroidVDA

Add support for H264 and VP9 to AndroidVDA

Previously the AndroidVideoDecodeAccelerator only supported
VP8. Now it has experimental support for VP9 and H264.

BUG=511375, 507834
TEST=Manually play h264 src= video in chrome shell

Committed: https://crrev.com/9b16970b9f3b8b28054d32b15099bffe55ec1722
Cr-Commit-Position: refs/heads/master@{#343278}

[watk, 2015-08-07 23:49:11]

watk@chromium.org changed reviewers:
+ sandersd@chromium.org

[sandersd (OOO until July 31), 2015-08-08 00:17:45]

LGTM % in-person discussion about comments.

https://codereview.chromium.org/1282083003/diff/1/content/common/gpu/media/an...
File content/common/gpu/media/android_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1282083003/diff/1/content/common/gpu/media/an...
content/common/gpu/media/android_video_decode_accelerator.cc:95: DVLOG(1) <<
"Unsupported profile: " << profile;
return false;

[Pawel Osciak, 2015-08-08 21:00:57]

posciak@chromium.org changed reviewers:
+ posciak@chromium.org

[Pawel Osciak, 2015-08-08 21:00:58]

https://codereview.chromium.org/1282083003/diff/1/content/renderer/media/rtc_...
File content/renderer/media/rtc_video_decoder.cc (right):

https://codereview.chromium.org/1282083003/diff/1/content/renderer/media/rtc_...
content/renderer/media/rtc_video_decoder.cc:664: // The AndroidVDA support for
VP9 and H264 is experimental, so disable it for
Would it be possible to just have VP8 only in supported profiles returned from 
AndroidVDA::GetSupportedProfiles() instead if we'd like to disable VP9 and H264?

[watk, 2015-08-10 18:16:24]

On 2015/08/08 21:00:58, Pawel Osciak wrote:
>
https://codereview.chromium.org/1282083003/diff/1/content/renderer/media/rtc_...
> File content/renderer/media/rtc_video_decoder.cc (right):
> 
>
https://codereview.chromium.org/1282083003/diff/1/content/renderer/media/rtc_...
> content/renderer/media/rtc_video_decoder.cc:664: // The AndroidVDA support for
> VP9 and H264 is experimental, so disable it for
> Would it be possible to just have VP8 only in supported profiles returned from

> AndroidVDA::GetSupportedProfiles() instead if we'd like to disable VP9 and
H264?

We'd only like to disable it in the case of RTCVideoDecoder because it
hasn't been well tested yet and there's a known bug with h264 and
MediaCodec (http://crbug.com/516540). The desktop media pipeline is
being enabled for Android behind a compile time flag, and for this we
need AVDA to support h264 and vp9 (http://crbug.com/507834).

We could ifdef out the h264 and vp9 support when it's not
being built with the mentioned flag. WDYT?

[watk, 2015-08-10 20:18:33]

> We could ifdef out the h264 and vp9 support when it's not
> being built with the mentioned flag. WDYT?

I implemented this in PS3. I think it's better. sandersd?

[sandersd (OOO until July 31), 2015-08-10 20:22:21]

Still LGTM if this is the pattern we want to follow.

[watk, 2015-08-10 23:52:19]

I'll wait for you to take a look at this posciak@.

[DaleCurtis, 2015-08-11 19:15:46]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2015-08-11 19:15:46]

https://codereview.chromium.org/1282083003/diff/40001/content/common/gpu/medi...
File content/common/gpu/media/android_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1282083003/diff/40001/content/common/gpu/medi...
content/common/gpu/media/android_video_decode_accelerator.cc:592:
profile.profile = media::H264PROFILE_BASELINE;
As discussed offline we should go ahead and include all profiles, if MediaCodec
fails to configure there's nothing we can do about it for h264 anyways.

[watk, 2015-08-11 20:07:47]

https://codereview.chromium.org/1282083003/diff/40001/content/common/gpu/medi...
File content/common/gpu/media/android_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1282083003/diff/40001/content/common/gpu/medi...
content/common/gpu/media/android_video_decode_accelerator.cc:592:
profile.profile = media::H264PROFILE_BASELINE;
On 2015/08/11 19:15:46, DaleCurtis wrote:
> As discussed offline we should go ahead and include all profiles, if
MediaCodec
> fails to configure there's nothing we can do about it for h264 anyways.

Done.

[DaleCurtis, 2015-08-11 22:57:44]

lgtm

[watk, 2015-08-12 18:17:08]

On 2015/08/11 22:57:44, DaleCurtis wrote:
> lgtm

I'm going to submit this posciak@. Let me know if you have any concerns and I'll
address them in a follow up.

[watk, 2015-08-12 18:17:13]

The CQ bit was checked by watk@chromium.org

[watk, 2015-08-12 18:17:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/1282083003/#ps60001
(title: "Support all h264 profiles")

[commit-bot: I haz the power, 2015-08-12 18:17:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282083003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282083003/60001

[commit-bot: I haz the power, 2015-08-12 19:31:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-12 19:31:15]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[watk, 2015-08-13 16:13:37]

The CQ bit was checked by watk@chromium.org

[watk, 2015-08-13 16:13:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org, sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/1282083003/#ps80001
(title: "Move kSupportedH264Profiles into #ifdef")

[commit-bot: I haz the power, 2015-08-13 16:13:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282083003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282083003/80001

[commit-bot: I haz the power, 2015-08-13 16:32:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-13 16:32:45]

Try jobs failed on following builders:
  linux_arm_compile on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi...)

[watk, 2015-08-13 20:26:28]

The CQ bit was checked by watk@chromium.org

[commit-bot: I haz the power, 2015-08-13 20:26:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282083003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282083003/80001

[commit-bot: I haz the power, 2015-08-13 21:30:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-13 21:31:12]

Patchset 5 (id:??) landed as
https://crrev.com/9b16970b9f3b8b28054d32b15099bffe55ec1722
Cr-Commit-Position: refs/heads/master@{#343278}