Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: content/child/background_sync/background_sync_provider.h

Issue 1282013004: BackgroundSyncManager tracks client registrations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed test Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/background_sync/background_sync_provider.h
diff --git a/content/child/background_sync/background_sync_provider.h b/content/child/background_sync/background_sync_provider.h
index 43d54d5393cf5e9b6a370978de06b7890af78afe..768555dd7cf0208b3cb7476b6f4118756a07e39d 100644
--- a/content/child/background_sync/background_sync_provider.h
+++ b/content/child/background_sync/background_sync_provider.h
@@ -28,14 +28,17 @@ class BackgroundSyncProvider : public blink::WebSyncProvider {
~BackgroundSyncProvider() override;
// blink::WebSyncProvider implementation
+ // TODO(jkarlin) convert int64_t handle_id to int handle_id in all
+ // WebSyncProvider functions.
void registerBackgroundSync(
const blink::WebSyncRegistration* options,
blink::WebServiceWorkerRegistration* service_worker_registration,
bool requested_from_service_worker,
blink::WebSyncRegistrationCallbacks* callbacks);
+ // TODO(jkarlin) remove |tag| parameter.
void unregisterBackgroundSync(
blink::WebSyncRegistration::Periodicity periodicity,
- int64_t id,
+ int64_t handle_id,
const blink::WebString& tag,
blink::WebServiceWorkerRegistration* service_worker_registration,
blink::WebSyncUnregistrationCallbacks* callbacks);
@@ -52,6 +55,13 @@ class BackgroundSyncProvider : public blink::WebSyncProvider {
blink::WebSyncRegistration::Periodicity periodicity,
blink::WebServiceWorkerRegistration* service_worker_registration,
blink::WebSyncGetPermissionStatusCallbacks* callbacks);
+ // TODO(jkarlin): Rename to releaseRegistrationHandle.
+ void releaseRegistration(int64_t handle_id);
+
+ void DuplicateRegistrationHandle(
+ int handle_id,
+ const BackgroundSyncService::DuplicateRegistrationHandleCallback&
+ callback);
private:
// Callback handlers
« no previous file with comments | « content/browser/service_worker/service_worker_version.cc ('k') | content/child/background_sync/background_sync_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698