BackgroundSyncManager tracks client registrations

content/renderer/service_worker/service_worker_context_client.cc

Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index de57d4ce2afe15b41ccd6e2fe73f9b2ed3a1d0c2..5d9d4523282ea13c45bb6475304d537d8dc9d538 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -353,12 +353,17 @@ void ServiceWorkerContextClient::workerContextStarted(
   // willDestroyWorkerContext.
   context_.reset(new WorkerContextData(this));
 
+  ServiceWorkerRegistrationObjectInfo registration_info;
+  ServiceWorkerVersionAttributes version_attrs;
+  provider_context_->GetRegistrationInfoAndVersionAttributes(&registration_info,

[michaeln, 2015/08/28 02:53:11]

there's an early return in GetRegistrationInfoAndVersionAttributes where it can
return false but for a worker context it never should go down that route, can
you add a...

DCHECK_NE(registration_info.registration_id,
kInvalidServiceWorkerRegistrationId)

[jkarlin, 2015/09/02 23:51:41]

Done.

[jkarlin, 2015/09/03 14:21:01]

Hmm, the DCHECK_NE is failing for
IN_PROC_BROWSER_TEST_F(EmbeddedWorkerBrowserTest, StartAndStop) because it
doesn't create a registration before starting the worker :( 

+                                                             &version_attrs);
+
   // Register Mojo services.
   context_->service_registry.ServiceRegistry::AddService(
       base::Bind(&ServicePortDispatcherImpl::Create,
                  context_->proxy_weak_factory.GetWeakPtr()));
-  context_->service_registry.ServiceRegistry::AddService(
-      base::Bind(&BackgroundSyncClientImpl::Create));
+  context_->service_registry.ServiceRegistry::AddService(base::Bind(
+      &BackgroundSyncClientImpl::Create, registration_info.registration_id));
 
   SetRegistrationInServiceWorkerGlobalScope();