content/browser/background_sync/background_sync_registration.cc - Issue 1282013004: BackgroundSyncManager tracks client registrations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_registration.cc

Issue 1282013004: BackgroundSyncManager tracks client registrations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from PS12 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/background_sync/background_sync_registration.cc

diff --git a/content/browser/background_sync/background_sync_registration.cc b/content/browser/background_sync/background_sync_registration.cc

index 427580a4174186c7ee6147f44865fe28001a7015..25f9ae96bd973b9237e6a25af5ac8ff7354896b7 100644

--- a/content/browser/background_sync/background_sync_registration.cc

+++ b/content/browser/background_sync/background_sync_registration.cc

@@ -80,6 +80,7 @@ namespace content {

// TODO(thakis): Remove this once http://crbug.com/488634 is fixed.

BackgroundSyncRegistration::BackgroundSyncRegistration() = default;

+BackgroundSyncRegistration::~BackgroundSyncRegistration() {}

michaeln 2015/08/19 01:56:01 deletion has no semantic meaning

jkarlin 2015/08/19 12:47:06 Made default.

const BackgroundSyncRegistration::RegistrationId

BackgroundSyncRegistration::kInvalidRegistrationId = -1;