BackgroundSyncManager tracks client registrations

content/browser/background_sync/background_sync_registration.h

Index: content/browser/background_sync/background_sync_registration.h
diff --git a/content/browser/background_sync/background_sync_registration.h b/content/browser/background_sync/background_sync_registration.h
index 94d764811eb6fc2136fa96e1e71f78894af5067d..26986751beadbdf58acfd6d35d61136107cc05fd 100644
--- a/content/browser/background_sync/background_sync_registration.h
+++ b/content/browser/background_sync/background_sync_registration.h
@@ -18,8 +18,11 @@ class CONTENT_EXPORT BackgroundSyncRegistration {
  public:
   using RegistrationId = int64_t;
   static const RegistrationId kInitialId;
+  static const RegistrationId kInvalidRegistrationId;

[iclelland, 2015/08/14 14:44:18]

Is this just for consistency? It doesn't look like you've changed where or how
it is accessed at all

[jkarlin, 2015/08/17 17:14:49]

Needed it but then didn't, forgot to clean up. Thanks. Done.

 
   BackgroundSyncRegistration();
+  virtual ~BackgroundSyncRegistration();
+
   bool Equals(const BackgroundSyncRegistration& other) const;
   bool IsValid() const;
 
@@ -33,11 +36,12 @@ class CONTENT_EXPORT BackgroundSyncRegistration {
   void set_sync_state(SyncState state) { sync_state_ = state; }
 
  private:
-  static const RegistrationId kInvalidRegistrationId;
 
   BackgroundSyncRegistrationOptions options_;
   RegistrationId id_ = kInvalidRegistrationId;
   SyncState sync_state_ = SYNC_STATE_PENDING;
+
+  DISALLOW_COPY_AND_ASSIGN(BackgroundSyncRegistration);

[iclelland, 2015/08/14 14:44:18]

Should there be an include for this, or is it enough that it's included
somewhere else transitively?
(Obviously, this is sufficient for the compiler right now)

[jkarlin, 2015/08/17 17:14:49]

Done.

 };
 
 }  // namespace content