BackgroundSyncManager tracks client registrations

content/child/background_sync/background_sync_provider.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/background_sync/background_sync_provider.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/child/background_sync/background_sync_type_converters.h"
 #include "content/child/service_worker/web_service_worker_registration_impl.h"
@@ skipping 40 matching lines @@
 
   // base::Unretained is safe here, as the mojo channel will be deleted (and
   // will wipe its callbacks) before 'this' is deleted.
   GetBackgroundSyncServicePtr()->Register(
       mojo::ConvertTo<SyncRegistrationPtr>(*(optionsPtr.get())),
       service_worker_registration_id,
       base::Bind(&BackgroundSyncProvider::RegisterCallback,
                  base::Unretained(this), base::Passed(callbacksPtr.Pass())));
 }
 
+// TODO(jkarlin) remove |tag| parameter.
 void BackgroundSyncProvider::unregisterBackgroundSync(
     blink::WebSyncRegistration::Periodicity periodicity,
     int64_t id,
     const blink::WebString& tag,
     blink::WebServiceWorkerRegistration* service_worker_registration,
     blink::WebSyncUnregistrationCallbacks* callbacks) {
   DCHECK(service_worker_registration);
   DCHECK(callbacks);
   int64 service_worker_registration_id =
       GetServiceWorkerRegistrationId(service_worker_registration);
   scoped_ptr<blink::WebSyncUnregistrationCallbacks> callbacksPtr(callbacks);
 
   // base::Unretained is safe here, as the mojo channel will be deleted (and
   // will wipe its callbacks) before 'this' is deleted.
   GetBackgroundSyncServicePtr()->Unregister(
-      mojo::ConvertTo<BackgroundSyncPeriodicity>(periodicity), id, tag.utf8(),
+      mojo::ConvertTo<BackgroundSyncPeriodicity>(periodicity), id,
       service_worker_registration_id,
       base::Bind(&BackgroundSyncProvider::UnregisterCallback,
                  base::Unretained(this), base::Passed(callbacksPtr.Pass())));
 }
 
 void BackgroundSyncProvider::getRegistration(
     blink::WebSyncRegistration::Periodicity periodicity,
     const blink::WebString& tag,
     blink::WebServiceWorkerRegistration* service_worker_registration,
     blink::WebSyncRegistrationCallbacks* callbacks) {
@@ skipping 44 matching lines @@
 
   // base::Unretained is safe here, as the mojo channel will be deleted (and
   // will wipe its callbacks) before 'this' is deleted.
   GetBackgroundSyncServicePtr()->GetPermissionStatus(
       mojo::ConvertTo<BackgroundSyncPeriodicity>(periodicity),
       service_worker_registration_id,
       base::Bind(&BackgroundSyncProvider::GetPermissionStatusCallback,
                  base::Unretained(this), base::Passed(callbacksPtr.Pass())));
 }
 
+void BackgroundSyncProvider::trackRegistration(
+    blink::WebSyncRegistration* registration) {
+  scoped_ptr<blink::WebSyncRegistration> scoped_registration(registration);

[michaeln, 2015/08/21 02:39:24]

is WebSyncRegistration thread safe?

no, it has a WebString data member :(

[jkarlin, 2015/08/25 17:32:58]

Good catch. This function is gone now but this is an existing problem with the
file, tracking in https://crbug.com/524017

+  GetBackgroundSyncServicePtr()->TrackRegistration(
+      mojo::ConvertTo<SyncRegistrationPtr>(*registration));
+}
+
+void BackgroundSyncProvider::releaseRegistration(int64_t sync_id) {
+  GetBackgroundSyncServicePtr()->ReleaseRegistration(sync_id);
+}
+
 void BackgroundSyncProvider::RegisterCallback(
     scoped_ptr<blink::WebSyncRegistrationCallbacks> callbacks,
     BackgroundSyncError error,
     const SyncRegistrationPtr& options) {
   // TODO(iclelland): Determine the correct error message to return in each case
   scoped_ptr<blink::WebSyncRegistration> result;
   switch (error) {
     case BACKGROUND_SYNC_ERROR_NONE:
       if (!options.is_null())
         result =
@@ skipping 163 matching lines @@
 BackgroundSyncServicePtr&
 BackgroundSyncProvider::GetBackgroundSyncServicePtr() {
   if (!background_sync_service_.get()) {
     service_registry_->ConnectToRemoteService(
         mojo::GetProxy(&background_sync_service_));
   }
   return background_sync_service_;
 }
 
 }  // namespace content