Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1282013002: [es6] Add appropriate ToString call to String.prototype.normalize (Closed)

Created:
5 years, 4 months ago by adamk
Modified:
5 years, 4 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Add appropriate ToString call to String.prototype.normalize R=littledan@chromium.org BUG=v8:4304 LOG=n Committed: https://crrev.com/f2acba0e8c0adc16fe6235f74067df771f500092 Cr-Commit-Position: refs/heads/master@{#30098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M src/i18n.js View 2 chunks +2 lines, -1 line 0 comments Download
M src/string.js View 2 chunks +2 lines, -1 line 0 comments Download
M test/test262-es6/test262-es6.status View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
adamk
5 years, 4 months ago (2015-08-07 18:29:21 UTC) #1
adamk
Ping?
5 years, 4 months ago (2015-08-10 18:17:57 UTC) #2
Dan Ehrenberg
lgtm
5 years, 4 months ago (2015-08-10 23:43:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282013002/1
5 years, 4 months ago (2015-08-10 23:45:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 00:12:03 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 00:12:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2acba0e8c0adc16fe6235f74067df771f500092
Cr-Commit-Position: refs/heads/master@{#30098}

Powered by Google App Engine
This is Rietveld 408576698