Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: pkg/analysis_server/test/edit/refactoring_test.dart

Issue 1281983002: Check for reset during 'await' in refactoring manager. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/edit/edit_domain.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/edit/refactoring_test.dart
diff --git a/pkg/analysis_server/test/edit/refactoring_test.dart b/pkg/analysis_server/test/edit/refactoring_test.dart
index 9b144296f4c4a34cf0b03112c37eb2a9f5bb896e..c5d61569caf648aa19c7972bd04d5ed167b296bc 100644
--- a/pkg/analysis_server/test/edit/refactoring_test.dart
+++ b/pkg/analysis_server/test/edit/refactoring_test.dart
@@ -269,6 +269,9 @@ class ExtractLocalVariableTest extends _AbstractGetRefactoring_Test {
test_simulateRefactoringException_init = false;
test_simulateRefactoringException_final = false;
test_simulateRefactoringException_change = false;
+ test_simulateRefactoringReset_afterInitialConditions = false;
+ test_simulateRefactoringReset_afterFinalConditions = false;
+ test_simulateRefactoringReset_afterCreateChange = false;
super.tearDown();
}
@@ -367,6 +370,48 @@ main() {
});
}
+ test_reset_afterCreateChange() {
+ test_simulateRefactoringReset_afterCreateChange = true;
+ addTestFile('''
+main() {
+ print(1 + 2);
+}
+''');
+ return waitForTasksFinished().then((_) {
+ return sendStringRequest('1 + 2', 'res', true).then((response) {
+ _expectRefactoringRequestCancelled(response);
+ });
+ });
+ }
+
+ test_reset_afterFinalConditions() {
+ test_simulateRefactoringReset_afterFinalConditions = true;
+ addTestFile('''
+main() {
+ print(1 + 2);
+}
+''');
+ return waitForTasksFinished().then((_) {
+ return sendStringRequest('1 + 2', 'res', true).then((response) {
+ _expectRefactoringRequestCancelled(response);
+ });
+ });
+ }
+
+ test_reset_afterInitialConditions() {
+ test_simulateRefactoringReset_afterInitialConditions = true;
+ addTestFile('''
+main() {
+ print(1 + 2);
+}
+''');
+ return waitForTasksFinished().then((_) {
+ return sendStringRequest('1 + 2', 'res', true).then((response) {
+ _expectRefactoringRequestCancelled(response);
+ });
+ });
+ }
+
test_serverError_change() {
test_simulateRefactoringException_change = true;
addTestFile('''
@@ -411,6 +456,12 @@ main() {
});
});
}
+
+ void _expectRefactoringRequestCancelled(Response response) {
+ expect(response.error, isNotNull);
+ expect(response,
+ isResponseFailure('0', RequestErrorCode.REFACTORING_REQUEST_CANCELLED));
+ }
}
@reflectiveTest
« no previous file with comments | « pkg/analysis_server/lib/src/edit/edit_domain.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698