Index: build/android/pylib/device/device_utils.py |
diff --git a/build/android/pylib/device/device_utils.py b/build/android/pylib/device/device_utils.py |
index 2d9671d01034f64873c5c0ebd2b889f0e896703c..f693aac7e2c5139a8df40e4ade56e173e82d6e60 100644 |
--- a/build/android/pylib/device/device_utils.py |
+++ b/build/android/pylib/device/device_utils.py |
@@ -1766,7 +1766,7 @@ class DeviceUtils(object): |
self._cache.clear() |
@classmethod |
- def parallel(cls, devices=None, async=False): |
+ def parallel(cls, devices, async=False): |
"""Creates a Parallelizer to operate over the provided list of devices. |
If |devices| is either |None| or an empty list, the Parallelizer will |
@@ -1783,9 +1783,7 @@ class DeviceUtils(object): |
A Parallelizer operating over |devices|. |
""" |
if not devices: |
- devices = cls.HealthyDevices() |
- if not devices: |
- raise device_errors.NoDevicesError() |
+ raise device_errors.NoDevicesError() |
devices = [d if isinstance(d, cls) else cls(d) for d in devices] |
if async: |
@@ -1794,10 +1792,14 @@ class DeviceUtils(object): |
return parallelizer.SyncParallelizer(devices) |
@classmethod |
- def HealthyDevices(cls): |
- blacklist = device_blacklist.ReadBlacklist() |
+ def HealthyDevices(cls, blacklist=None): |
+ if not blacklist: |
jbudorick
2015/08/13 17:38:17
Ethan: the None blacklist currently gets handled h
|
+ # TODO(jbudorick): Remove once clients pass in the blacklist. |
+ blacklist = device_blacklist.Blacklist(device_blacklist.BLACKLIST_JSON) |
+ |
+ blacklisted_devices = blacklist.Read() |
def blacklisted(adb): |
- if adb.GetDeviceSerial() in blacklist: |
+ if adb.GetDeviceSerial() in blacklisted_devices: |
logging.warning('Device %s is blacklisted.', adb.GetDeviceSerial()) |
return True |
return False |