Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1281923002: [GC] Remove FLAG_incremental_marking_steps (Closed)

Created:
5 years, 4 months ago by Michael Lippautz
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[GC] Remove FLAG_incremental_marking_steps BUG= Committed: https://crrev.com/6a8cb1756a0f6c3deee9db0fb968cf145f2b1582 Cr-Commit-Position: refs/heads/master@{#30083}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/incremental-marking.cc View 3 chunks +1 line, -4 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Lippautz
As discussed this week, let's get rid of the flag.
5 years, 4 months ago (2015-08-07 14:40:34 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-08-10 08:21:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281923002/1
5 years, 4 months ago (2015-08-10 08:28:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 08:53:39 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 08:53:53 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6a8cb1756a0f6c3deee9db0fb968cf145f2b1582
Cr-Commit-Position: refs/heads/master@{#30083}

Powered by Google App Engine
This is Rietveld 408576698