chrome/browser/update_client/chrome_update_query_params_delegate_unittest.cc - Issue 1281913002: Componentize ComponentUpdaterConfigurator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/update_client/chrome_update_query_params_delegate_unittest.cc

Issue 1281913002: Componentize ComponentUpdaterConfigurator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix iOS compile Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/update_client/chrome_update_query_params_delegate.cc ('k') | chrome/chrome_browser.gypi » ('j') | components/component_updater/component_updater_url_constants.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/update_client/chrome_update_query_params_delegate_unittest.cc

diff --git a/chrome/browser/update_client/chrome_update_query_params_delegate_unittest.cc b/chrome/browser/update_client/chrome_update_query_params_delegate_unittest.cc

index 5525d88b1cb3723d5c776793fd5d4d83d7db3736..0c47cba2bac8a33c42f5cede4403f083e7acd217 100644

--- a/chrome/browser/update_client/chrome_update_query_params_delegate_unittest.cc

+++ b/chrome/browser/update_client/chrome_update_query_params_delegate_unittest.cc

@@ -6,6 +6,7 @@

#include "base/strings/stringprintf.h"

#include "chrome/browser/update_client/chrome_update_query_params_delegate.h"

+#include "chrome/common/channel_info.h"

#include "components/update_client/update_query_params.h"

#include "components/version_info/version_info.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -35,8 +36,7 @@ void TestParams(update_client::UpdateQueryParams::ProdId prod_id) {

update_client::UpdateQueryParams::GetProdIdString(prod_id))));

EXPECT_TRUE(Contains(

params,

- StringPrintf("prodchannel=%s",

- ChromeUpdateQueryParamsDelegate::GetChannelString())));

+ StringPrintf("prodchannel=%s", chrome::GetChannelString().c_str())));

EXPECT_TRUE(

Contains(params, StringPrintf("prodversion=%s",

version_info::GetVersionNumber().c_str())));