Componentize ComponentUpdaterConfigurator

components/update_client/update_query_params.h

Index: components/update_client/update_query_params.h
diff --git a/components/update_client/update_query_params.h b/components/update_client/update_query_params.h
index 48f7acfb5b07dd4549693905ec19497de7e300ea..2af72bfe3297619b7d0dad71c92d5e2339624592 100644
--- a/components/update_client/update_query_params.h
+++ b/components/update_client/update_query_params.h
@@ -8,6 +8,7 @@
 #include <string>
 
 #include "base/basictypes.h"
+#include "components/version_info/version_info.h"
 
 namespace update_client {
 
@@ -51,6 +52,11 @@ class UpdateQueryParams {
   // Use this delegate.
   static void SetDelegate(UpdateQueryParamsDelegate* delegate);
 
+  // Returns the value we use for the "updaterchannel=" and "prodchannel="
+  // parameters. Possible return values include: "canary", "dev", "beta", and
+  // "stable".
+  static const char* GetChannelString(version_info::Channel channel);

[sdefresne, 2015/08/13 12:20:00]

version_info::Channel is a "enum class" and thus can be forward-declared, please
do so and only include the header in the implementation file.

namespace version_info {
enum class Channel;
}

[droger, 2015/08/13 13:16:02]

Done, using version_info instead, which actually simplifies the code a lot.
sorin: was there a good reason to have duplication here?

[droger, 2015/08/13 13:17:46]

Sorry this was meant as a reply to another comment. I have replied at the right
place now.

+
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(UpdateQueryParams);
 };