Componentize ComponentUpdaterConfigurator

ios/chrome/browser/component_updater/component_updater_configurator.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ios/chrome/browser/component_updater/component_updater_configurator.h"
+
+#include <string>
+
+#include "base/threading/sequenced_worker_pool.h"
+#include "components/component_updater/default_configurator.h"
+#include "components/update_client/component_patcher_operation.h"
+#include "components/update_client/update_query_params_delegate.h"
+#include "ios/chrome/browser/application_context.h"
+#include "ios/chrome/common/channel_info.h"
+#include "ios/web/public/web_thread.h"
+
+namespace component_updater {
+
+namespace {
+
+class ChromeConfigurator : public DefaultConfigurator {
+ public:
+  ChromeConfigurator(const base::CommandLine* cmdline,
+                     net::URLRequestContextGetter* url_request_getter);
+
+  std::string GetChannel() const override;
+  std::string GetLang() const override;
+  scoped_refptr<update_client::OutOfProcessPatcher> CreateOutOfProcessPatcher()
+      const override;
+  scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner()
+      const override;
+  scoped_refptr<base::SingleThreadTaskRunner> GetSingleThreadTaskRunner()
+      const override;
+
+ private:
+  friend class base::RefCountedThreadSafe<ChromeConfigurator>;
+
+  ~ChromeConfigurator() override {}
+};
+
+ChromeConfigurator::ChromeConfigurator(
+    const base::CommandLine* cmdline,
+    net::URLRequestContextGetter* url_request_getter)
+    : DefaultConfigurator(cmdline, url_request_getter) {}
+
+std::string ChromeConfigurator::GetChannel() const {
+  return update_client::UpdateQueryParamsDelegate::GetChannelStringHelper(
+      ::GetChannel());
+}
+
+std::string ChromeConfigurator::GetLang() const {
+  return GetApplicationContext()->GetApplicationLocale();
+}
+
+scoped_refptr<update_client::OutOfProcessPatcher>
+ChromeConfigurator::CreateOutOfProcessPatcher() const {
+  return nullptr;

[droger, 2015/08/07 14:49:44]

Is it fine to return null here? On iOS we can't do anything out of process.

[Sorin Jianu, 2015/08/12 02:27:51]

It is correct to return nullptr in this case, according to
https://code.google.com/p/chromium/codesearch#chromium/src/components/update_...

and the code at: 
https://code.google.com/p/chromium/codesearch#chromium/src/components/update_...

+}
+
+scoped_refptr<base::SequencedTaskRunner>
+ChromeConfigurator::GetSequencedTaskRunner() const {
+  return web::WebThread::GetBlockingPool()
+      ->GetSequencedTaskRunnerWithShutdownBehavior(
+          web::WebThread::GetBlockingPool()->GetSequenceToken(),
+          base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);
+}
+
+scoped_refptr<base::SingleThreadTaskRunner>
+ChromeConfigurator::GetSingleThreadTaskRunner() const {
+  return web::WebThread::GetTaskRunnerForThread(web::WebThread::FILE);
+}
+
+}  // namespace
+
+scoped_refptr<update_client::Configurator> MakeComponentUpdaterConfigurator(
+    const base::CommandLine* cmdline,
+    net::URLRequestContextGetter* context_getter) {
+  return new ChromeConfigurator(cmdline, context_getter);
+}
+
+}  // namespace component_updater