Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: chrome/browser/component_updater/chrome_component_updater_configurator.cc

Issue 1281913002: Componentize ComponentUpdaterConfigurator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix iOS compile Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/component_updater/chrome_component_updater_configurator .h" 5 #include "chrome/browser/component_updater/chrome_component_updater_configurator .h"
6 6
7 #include <algorithm>
8 #include <string> 7 #include <string>
9 #include <vector>
10 8
11 #include "base/command_line.h" 9 #include "base/threading/sequenced_worker_pool.h"
12 #include "base/compiler_specific.h"
13 #include "base/strings/string_split.h"
14 #include "base/strings/string_util.h"
15 #include "base/version.h" 10 #include "base/version.h"
16 #include "build/build_config.h"
17 #include "chrome/browser/component_updater/component_patcher_operation_out_of_pr ocess.h" 11 #include "chrome/browser/component_updater/component_patcher_operation_out_of_pr ocess.h"
18 #include "chrome/browser/component_updater/component_updater_url_constants.h"
19 #include "chrome/browser/update_client/chrome_update_query_params_delegate.h" 12 #include "chrome/browser/update_client/chrome_update_query_params_delegate.h"
20 #include "components/component_updater/component_updater_switches.h" 13 #include "chrome/common/channel_info.h"
21 #include "components/update_client/configurator.h" 14 #include "components/component_updater/configurator_impl.h"
22 #include "components/version_info/version_info.h"
23 #include "content/public/browser/browser_thread.h" 15 #include "content/public/browser/browser_thread.h"
24 #include "net/url_request/url_request_context_getter.h"
25 #include "url/gurl.h"
26
27 #if defined(OS_WIN)
28 #include "base/win/win_util.h"
29 #endif // OS_WIN
30
31 using update_client::Configurator;
32 using update_client::OutOfProcessPatcher;
33 16
34 namespace component_updater { 17 namespace component_updater {
35 18
36 namespace { 19 namespace {
37 20
38 // Default time constants. 21 class ChromeConfigurator : public update_client::Configurator {
39 const int kDelayOneMinute = 60;
40 const int kDelayOneHour = kDelayOneMinute * 60;
41
42 // Debug values you can pass to --component-updater=value1,value2.
43 // Speed up component checking.
44 const char kSwitchFastUpdate[] = "fast-update";
45
46 // Add "testrequest=1" attribute to the update check request.
47 const char kSwitchRequestParam[] = "test-request";
48
49 // Disables pings. Pings are the requests sent to the update server that report
50 // the success or the failure of component install or update attempts.
51 extern const char kSwitchDisablePings[] = "disable-pings";
52
53 // Sets the URL for updates.
54 const char kSwitchUrlSource[] = "url-source";
55
56 // Disables differential updates.
57 const char kSwitchDisableDeltaUpdates[] = "disable-delta-updates";
58
59 #if defined(OS_WIN)
60 // Disables background downloads.
61 const char kSwitchDisableBackgroundDownloads[] = "disable-background-downloads";
62 #endif // defined(OS_WIN)
63
64 // Returns true if and only if |test| is contained in |vec|.
65 bool HasSwitchValue(const std::vector<std::string>& vec, const char* test) {
66 if (vec.empty())
67 return 0;
68 return (std::find(vec.begin(), vec.end(), test) != vec.end());
69 }
70
71 // Returns true if falling back on an alternate, unsafe, service URL is
72 // allowed. In the fallback case, the security of the component update relies
73 // only on the integrity of the CRX payloads, which is self-validating.
74 // This is allowed only for some of the pre-Windows Vista versions not including
75 // Windows XP SP3. As a side note, pings could be sent to the alternate URL too.
76 bool CanUseAltUrlSource() {
77 #if defined(OS_WIN)
78 return !base::win::MaybeHasSHA256Support();
79 #else
80 return false;
81 #endif // OS_WIN
82 }
83
84 // If there is an element of |vec| of the form |test|=.*, returns the right-
85 // hand side of that assignment. Otherwise, returns an empty string.
86 // The right-hand side may contain additional '=' characters, allowing for
87 // further nesting of switch arguments.
88 std::string GetSwitchArgument(const std::vector<std::string>& vec,
89 const char* test) {
90 if (vec.empty())
91 return std::string();
92 for (std::vector<std::string>::const_iterator it = vec.begin();
93 it != vec.end();
94 ++it) {
95 const std::size_t found = it->find("=");
96 if (found != std::string::npos) {
97 if (it->substr(0, found) == test) {
98 return it->substr(found + 1);
99 }
100 }
101 }
102 return std::string();
103 }
104
105 class ChromeConfigurator : public Configurator {
106 public: 22 public:
107 ChromeConfigurator(const base::CommandLine* cmdline, 23 ChromeConfigurator(const base::CommandLine* cmdline,
108 net::URLRequestContextGetter* url_request_getter); 24 net::URLRequestContextGetter* url_request_getter);
109 25
26 // update_client::Configurator overrides.
110 int InitialDelay() const override; 27 int InitialDelay() const override;
111 int NextCheckDelay() const override; 28 int NextCheckDelay() const override;
112 int StepDelay() const override; 29 int StepDelay() const override;
113 int OnDemandDelay() const override; 30 int OnDemandDelay() const override;
114 int UpdateDelay() const override; 31 int UpdateDelay() const override;
115 std::vector<GURL> UpdateUrl() const override; 32 std::vector<GURL> UpdateUrl() const override;
116 std::vector<GURL> PingUrl() const override; 33 std::vector<GURL> PingUrl() const override;
117 base::Version GetBrowserVersion() const override; 34 base::Version GetBrowserVersion() const override;
118 std::string GetChannel() const override; 35 std::string GetChannel() const override;
119 std::string GetLang() const override; 36 std::string GetLang() const override;
120 std::string GetOSLongName() const override; 37 std::string GetOSLongName() const override;
121 std::string ExtraRequestParams() const override; 38 std::string ExtraRequestParams() const override;
122 net::URLRequestContextGetter* RequestContext() const override; 39 net::URLRequestContextGetter* RequestContext() const override;
123 scoped_refptr<OutOfProcessPatcher> CreateOutOfProcessPatcher() const override; 40 scoped_refptr<update_client::OutOfProcessPatcher> CreateOutOfProcessPatcher()
41 const override;
124 bool DeltasEnabled() const override; 42 bool DeltasEnabled() const override;
125 bool UseBackgroundDownloader() const override; 43 bool UseBackgroundDownloader() const override;
126 scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner() 44 scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner()
127 const override; 45 const override;
128 scoped_refptr<base::SingleThreadTaskRunner> GetSingleThreadTaskRunner() 46 scoped_refptr<base::SingleThreadTaskRunner> GetSingleThreadTaskRunner()
129 const override; 47 const override;
130 48
131 private: 49 private:
132 friend class base::RefCountedThreadSafe<ChromeConfigurator>; 50 friend class base::RefCountedThreadSafe<ChromeConfigurator>;
133 51
52 ConfiguratorImpl configurator_impl_;
53
134 ~ChromeConfigurator() override {} 54 ~ChromeConfigurator() override {}
135
136 net::URLRequestContextGetter* url_request_getter_;
137 std::string extra_info_;
138 GURL url_source_override_;
139 bool fast_update_;
140 bool pings_enabled_;
141 bool deltas_enabled_;
142 bool background_downloads_enabled_;
143 bool fallback_to_alt_source_url_enabled_;
144 }; 55 };
145 56
146 ChromeConfigurator::ChromeConfigurator( 57 ChromeConfigurator::ChromeConfigurator(
147 const base::CommandLine* cmdline, 58 const base::CommandLine* cmdline,
148 net::URLRequestContextGetter* url_request_getter) 59 net::URLRequestContextGetter* url_request_getter)
149 : url_request_getter_(url_request_getter), 60 : configurator_impl_(cmdline, url_request_getter) {}
150 fast_update_(false),
151 pings_enabled_(false),
152 deltas_enabled_(false),
153 background_downloads_enabled_(false),
154 fallback_to_alt_source_url_enabled_(false) {
155 // Parse comma-delimited debug flags.
156 std::vector<std::string> switch_values = base::SplitString(
157 cmdline->GetSwitchValueASCII(switches::kComponentUpdater),
158 ",", base::KEEP_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
159 fast_update_ = HasSwitchValue(switch_values, kSwitchFastUpdate);
160 pings_enabled_ = !HasSwitchValue(switch_values, kSwitchDisablePings);
161 deltas_enabled_ = !HasSwitchValue(switch_values, kSwitchDisableDeltaUpdates);
162
163 #if defined(OS_WIN)
164 background_downloads_enabled_ =
165 !HasSwitchValue(switch_values, kSwitchDisableBackgroundDownloads);
166 #else
167 background_downloads_enabled_ = false;
168 #endif
169
170 const std::string switch_url_source =
171 GetSwitchArgument(switch_values, kSwitchUrlSource);
172 if (!switch_url_source.empty()) {
173 url_source_override_ = GURL(switch_url_source);
174 DCHECK(url_source_override_.is_valid());
175 }
176
177 if (HasSwitchValue(switch_values, kSwitchRequestParam))
178 extra_info_ += "testrequest=\"1\"";
179
180 fallback_to_alt_source_url_enabled_ = CanUseAltUrlSource();
181 }
182 61
183 int ChromeConfigurator::InitialDelay() const { 62 int ChromeConfigurator::InitialDelay() const {
184 return fast_update_ ? 10 : (6 * kDelayOneMinute); 63 return configurator_impl_.InitialDelay();
185 } 64 }
186 65
187 int ChromeConfigurator::NextCheckDelay() const { 66 int ChromeConfigurator::NextCheckDelay() const {
188 return fast_update_ ? 60 : (6 * kDelayOneHour); 67 return configurator_impl_.NextCheckDelay();
189 } 68 }
190 69
191 int ChromeConfigurator::StepDelay() const { 70 int ChromeConfigurator::StepDelay() const {
192 return fast_update_ ? 1 : 1; 71 return configurator_impl_.StepDelay();
193 } 72 }
194 73
195 int ChromeConfigurator::OnDemandDelay() const { 74 int ChromeConfigurator::OnDemandDelay() const {
196 return fast_update_ ? 2 : (30 * kDelayOneMinute); 75 return configurator_impl_.OnDemandDelay();
197 } 76 }
198 77
199 int ChromeConfigurator::UpdateDelay() const { 78 int ChromeConfigurator::UpdateDelay() const {
200 return fast_update_ ? 10 : (15 * kDelayOneMinute); 79 return configurator_impl_.UpdateDelay();
201 } 80 }
202 81
203 std::vector<GURL> ChromeConfigurator::UpdateUrl() const { 82 std::vector<GURL> ChromeConfigurator::UpdateUrl() const {
204 std::vector<GURL> urls; 83 return configurator_impl_.UpdateUrl();
205 if (url_source_override_.is_valid()) {
206 urls.push_back(GURL(url_source_override_));
207 } else {
208 urls.push_back(GURL(kUpdaterDefaultUrl));
209 if (fallback_to_alt_source_url_enabled_) {
210 urls.push_back(GURL(kUpdaterAltUrl));
211 }
212 }
213 return urls;
214 } 84 }
215 85
216 std::vector<GURL> ChromeConfigurator::PingUrl() const { 86 std::vector<GURL> ChromeConfigurator::PingUrl() const {
217 return pings_enabled_ ? UpdateUrl() : std::vector<GURL>(); 87 return configurator_impl_.PingUrl();
218 } 88 }
219 89
220 base::Version ChromeConfigurator::GetBrowserVersion() const { 90 base::Version ChromeConfigurator::GetBrowserVersion() const {
221 return base::Version(version_info::GetVersionNumber()); 91 return configurator_impl_.GetBrowserVersion();
222 } 92 }
223 93
224 std::string ChromeConfigurator::GetChannel() const { 94 std::string ChromeConfigurator::GetChannel() const {
225 return ChromeUpdateQueryParamsDelegate::GetChannelString(); 95 return chrome::GetChannelString();
226 } 96 }
227 97
228 std::string ChromeConfigurator::GetLang() const { 98 std::string ChromeConfigurator::GetLang() const {
229 return ChromeUpdateQueryParamsDelegate::GetLang(); 99 return ChromeUpdateQueryParamsDelegate::GetLang();
230 } 100 }
231 101
232 std::string ChromeConfigurator::GetOSLongName() const { 102 std::string ChromeConfigurator::GetOSLongName() const {
233 return version_info::GetOSType(); 103 return configurator_impl_.GetOSLongName();
234 } 104 }
235 105
236 std::string ChromeConfigurator::ExtraRequestParams() const { 106 std::string ChromeConfigurator::ExtraRequestParams() const {
237 return extra_info_; 107 return configurator_impl_.ExtraRequestParams();
238 } 108 }
239 109
240 net::URLRequestContextGetter* ChromeConfigurator::RequestContext() const { 110 net::URLRequestContextGetter* ChromeConfigurator::RequestContext() const {
241 return url_request_getter_; 111 return configurator_impl_.RequestContext();
242 } 112 }
243 113
244 scoped_refptr<OutOfProcessPatcher> 114 scoped_refptr<update_client::OutOfProcessPatcher>
245 ChromeConfigurator::CreateOutOfProcessPatcher() const { 115 ChromeConfigurator::CreateOutOfProcessPatcher() const {
246 return make_scoped_refptr(new ChromeOutOfProcessPatcher); 116 return make_scoped_refptr(new ChromeOutOfProcessPatcher);
247 } 117 }
248 118
249 bool ChromeConfigurator::DeltasEnabled() const { 119 bool ChromeConfigurator::DeltasEnabled() const {
250 return deltas_enabled_; 120 return configurator_impl_.DeltasEnabled();
251 } 121 }
252 122
253 bool ChromeConfigurator::UseBackgroundDownloader() const { 123 bool ChromeConfigurator::UseBackgroundDownloader() const {
254 return background_downloads_enabled_; 124 return configurator_impl_.UseBackgroundDownloader();
255 } 125 }
256 126
257 scoped_refptr<base::SequencedTaskRunner> 127 scoped_refptr<base::SequencedTaskRunner>
258 ChromeConfigurator::GetSequencedTaskRunner() const { 128 ChromeConfigurator::GetSequencedTaskRunner() const {
259 return content::BrowserThread::GetBlockingPool() 129 return content::BrowserThread::GetBlockingPool()
260 ->GetSequencedTaskRunnerWithShutdownBehavior( 130 ->GetSequencedTaskRunnerWithShutdownBehavior(
261 content::BrowserThread::GetBlockingPool()->GetSequenceToken(), 131 content::BrowserThread::GetBlockingPool()->GetSequenceToken(),
262 base::SequencedWorkerPool::SKIP_ON_SHUTDOWN); 132 base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);
263 } 133 }
264 134
265 scoped_refptr<base::SingleThreadTaskRunner> 135 scoped_refptr<base::SingleThreadTaskRunner>
266 ChromeConfigurator::GetSingleThreadTaskRunner() const { 136 ChromeConfigurator::GetSingleThreadTaskRunner() const {
267 return content::BrowserThread::GetMessageLoopProxyForThread( 137 return content::BrowserThread::GetMessageLoopProxyForThread(
268 content::BrowserThread::FILE); 138 content::BrowserThread::FILE);
269 } 139 }
270 140
271 } // namespace 141 } // namespace
272 142
273 scoped_refptr<update_client::Configurator> 143 scoped_refptr<update_client::Configurator>
274 MakeChromeComponentUpdaterConfigurator( 144 MakeChromeComponentUpdaterConfigurator(
275 const base::CommandLine* cmdline, 145 const base::CommandLine* cmdline,
276 net::URLRequestContextGetter* context_getter) { 146 net::URLRequestContextGetter* context_getter) {
277 return new ChromeConfigurator(cmdline, context_getter); 147 return new ChromeConfigurator(cmdline, context_getter);
278 } 148 }
279 149
280 } // namespace component_updater 150 } // namespace component_updater
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698