Componentize ComponentUpdaterConfigurator

components/update_client/update_query_params.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_UPDATE_CLIENT_UPDATE_QUERY_PARAMS_H_
 #define COMPONENTS_UPDATE_CLIENT_UPDATE_QUERY_PARAMS_H_
 
 #include <string>
 
 #include "base/basictypes.h"
+#include "components/version_info/version_info.h"
 
 namespace update_client {
 
 class UpdateQueryParamsDelegate;
 
 // Generates a string of URL query parameters to be used when getting
 // component and extension updates. These parameters generally remain
 // fixed for a particular build. Embedders can use the delegate to
 // define different implementations. This should be used only in the
 // browser process.
@@ skipping 23 matching lines @@
 
   // Returns the value we use for the "nacl_arch" parameter. Note that this may
   // be different from the "arch" parameter above (e.g. one may be 32-bit and
   // the other 64-bit). Possible return values include: "x86-32", "x86-64",
   // "arm", and "mips32".
   static const char* GetNaclArch();
 
   // Use this delegate.
   static void SetDelegate(UpdateQueryParamsDelegate* delegate);
 
+  // Returns the value we use for the "updaterchannel=" and "prodchannel="
+  // parameters. Possible return values include: "canary", "dev", "beta", and
+  // "stable".
+  static const char* GetChannelString(version_info::Channel channel);

[sdefresne, 2015/08/13 12:20:00]

version_info::Channel is a "enum class" and thus can be forward-declared, please
do so and only include the header in the implementation file.

namespace version_info {
enum class Channel;
}

[droger, 2015/08/13 13:16:02]

Done, using version_info instead, which actually simplifies the code a lot.
sorin: was there a good reason to have duplication here?

[droger, 2015/08/13 13:17:46]

Sorry this was meant as a reply to another comment. I have replied at the right
place now.

+
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(UpdateQueryParams);
 };
 
 }  // namespace update_client
 
 #endif  // COMPONENTS_UPDATE_CLIENT_UPDATE_QUERY_PARAMS_H_