components/update_client/configurator.h - Issue 1281913002: Componentize ComponentUpdaterConfigurator

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/update_client/configurator.h

Issue 1281913002: Componentize ComponentUpdaterConfigurator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_UPDATE_CLIENT_CONFIGURATOR_H_	5 #ifndef COMPONENTS_UPDATE_CLIENT_CONFIGURATOR_H_

6 #define COMPONENTS_UPDATE_CLIENT_CONFIGURATOR_H_	6 #define COMPONENTS_UPDATE_CLIENT_CONFIGURATOR_H_

7	7

8 #include <string>	8 #include <string>

9 #include <vector>	9 #include <vector>

10	10

11 #include "base/memory/ref_counted.h"	11 #include "base/memory/ref_counted.h"

12 #include "base/memory/scoped_ptr.h"	12 #include "base/memory/scoped_ptr.h"

	13 #include "base/version.h"
	sdefresne 2015/08/13 12:20:00 Why adding this #include, the class is already for Why adding this #include, the class is already forward-declared below? If the #include is really required, at least remove the forward-declaration. droger 2015/08/13 13:16:02 Oops sorry, this is a mistake. Show quoted text On 2015/08/13 12:20:00, sdefresne wrote: > Why adding this #include, the class is already forward-declared below? If the > #include is really required, at least remove the forward-declaration. Oops sorry, this is a mistake.
13	14

14 class GURL;	15 class GURL;

15	16

16 namespace base {	17 namespace base {

17 class SingleThreadTaskRunner;	18 class SingleThreadTaskRunner;

18 class SequencedTaskRunner;	19 class SequencedTaskRunner;

19 class Version;	20 class Version;

20 }	21 }

21	22

22 namespace net {	23 namespace net {

(...skipping 82 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
105	106

106 protected:	107 protected:

107 friend class base::RefCountedThreadSafe<Configurator>;	108 friend class base::RefCountedThreadSafe<Configurator>;

108	109

109 virtual ~Configurator() {}	110 virtual ~Configurator() {}

110 };	111 };

111	112

112 } // namespace update_client	113 } // namespace update_client

113	114

114 #endif // COMPONENTS_UPDATE_CLIENT_CONFIGURATOR_H_	115 #endif // COMPONENTS_UPDATE_CLIENT_CONFIGURATOR_H_

OLD	NEW

« no previous file with comments | « components/update_client/DEPS ('k') | components/update_client/update_query_params.h » ('j') | components/update_client/update_query_params.h » ('J')