Rewrite Error.prototype.toString in C++.

src/messages.h

Index: src/messages.h
diff --git a/src/messages.h b/src/messages.h
index 529c659e181d8f35cca3e05909d8e3a76fa9a3b4..5c8e0504752a6d71beee12c7d6bd11753bda8e8c 100644
--- a/src/messages.h
+++ b/src/messages.h
@@ -457,6 +457,46 @@ class MessageHandler {
   static base::SmartArrayPointer<char> GetLocalizedMessage(Isolate* isolate,
                                                            Handle<Object> data);
 };
+
+
+class ErrorToStringHelper {
+ public:
+  ErrorToStringHelper() : visited_(0) {}
+
+  MUST_USE_RESULT MaybeHandle<String> Stringify(Isolate* isolate,
+                                                Handle<JSObject> error);
+
+ private:
+  class VisitedScope {
+   public:
+    VisitedScope(ErrorToStringHelper* helper, Handle<JSObject> error)
+        : helper_(helper), has_visited_(false) {
+      for (const auto& visited : helper->visited_) {

[Jakob Kummerow, 2015/08/08 21:56:09]

nit: I'd prefer the explicitness of s/auto/Handle<JSObject>/

+        if (visited.is_identical_to(error)) {
+          has_visited_ = true;
+          break;
+        }
+      }
+      helper->visited_.Add(error);
+    }
+    ~VisitedScope() { helper_->visited_.RemoveLast(); }
+    bool HasVisited() { return has_visited_; }

[Jakob Kummerow, 2015/08/08 21:56:09]

nit: unix_hacker_style() for simple getters

+
+   private:
+    ErrorToStringHelper* helper_;
+    bool has_visited_;
+  };
+
+

[Jakob Kummerow, 2015/08/08 21:56:09]

nit: one empty line is enough here

+  bool ShadowsInternalError(Isolate* isolate, LookupIterator* property_lookup,

[Jakob Kummerow, 2015/08/08 21:56:09]

this could be declared static, right?

+                            LookupIterator* internal_error_lookup);
+
+  MUST_USE_RESULT MaybeHandle<String> GetStringifiedProperty(

[Jakob Kummerow, 2015/08/08 21:56:09]

this could be declared static too, right?

+      Isolate* isolate, LookupIterator* property_lookup,
+      Handle<String> default_value);
+
+  List<Handle<JSObject> > visited_;
+};
 } }  // namespace v8::internal
 
 #endif  // V8_MESSAGES_H_