Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1281823002: Gallery: change size of crop overlay to cover entire window. (Closed)

Created:
5 years, 4 months ago by yawano
Modified:
5 years, 4 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: change size of crop overlay to cover entire window. Previously, size of crop overlay was same with it of an image. But since size calculation logics for crop overlay and an image are different, it causes gaps as issues describe. This CL changes crop overlay to cover entier window. BUG=498783, 516638 TEST=manually tested as described in the issues. Committed: https://crrev.com/bf3ca37da6d0007be86a963b98b79353176b0baf Cr-Commit-Position: refs/heads/master@{#342321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -54 lines) Patch
M ui/file_manager/gallery/css/gallery.css View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_editor.js View 1 chunk +0 lines, -28 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_transform.js View 3 chunks +24 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
5 years, 4 months ago (2015-08-07 06:39:08 UTC) #2
hirono
lgtm
5 years, 4 months ago (2015-08-07 08:05:38 UTC) #3
yawano
On 2015/08/07 08:05:38, hirono wrote: > lgtm Thank you!
5 years, 4 months ago (2015-08-07 08:15:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281823002/1
5 years, 4 months ago (2015-08-07 08:15:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 08:44:33 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 08:45:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf3ca37da6d0007be86a963b98b79353176b0baf
Cr-Commit-Position: refs/heads/master@{#342321}

Powered by Google App Engine
This is Rietveld 408576698