Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1281813002: Delete dart2js_extra/22895.dart; it is nearly identical to /dart2js_extra/22868_test.dart. (Closed)

Created:
5 years, 4 months ago by karlklose
Modified:
5 years, 4 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Delete dart2js_extra/22895.dart; it is nearly identical to /dart2js_extra/22868_test.dart. R=herhut@google.com Committed: https://github.com/dart-lang/sdk/commit/5e7a9dcfb4abc87f150cbe3f0a0a64fc1d3e5cf8

Patch Set 1 #

Patch Set 2 : Extend comment to mention other bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M tests/compiler/dart2js_extra/22868_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
D tests/compiler/dart2js_extra/22895_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
karlklose
5 years, 4 months ago (2015-08-07 06:09:56 UTC) #1
herhut
LGTM Maybe add a comment to the remaining test that it also tests regression for ...
5 years, 4 months ago (2015-08-07 08:12:23 UTC) #2
karlklose
Done.
5 years, 4 months ago (2015-08-07 08:27:42 UTC) #3
karlklose
5 years, 4 months ago (2015-08-07 08:27:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5e7a9dcfb4abc87f150cbe3f0a0a64fc1d3e5cf8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698