Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 1281793004: fix sorting of compilation unit members - related to #23947 (Closed)

Created:
5 years, 4 months ago by danrubel
Modified:
5 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix sorting of compilation unit members - related to #23947 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/da92573117ecc4a3715cf044a6fdf393ebdad8d9

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 4 months ago (2015-08-11 17:30:21 UTC) #2
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-08-11 17:40:58 UTC) #3
danrubel
5 years, 4 months ago (2015-08-11 18:24:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
da92573117ecc4a3715cf044a6fdf393ebdad8d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698