Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 128173002: Fix referrer policy passing during redirects (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 11 months ago
Reviewers:
nasko
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix referrer policy passing during redirects We a redirect commits, we should take the referrer policy from the request we actually send and not from the one we intended to send. Also, when the renderer tells the browser about a new navigation, always update the referrer together with the URL Depends on https://codereview.chromium.org/126753002/ in blink BUG=331941 R=nasko@chromium.org TEST=browser_tests:ReferrerPolicyTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244138

Patch Set 1 #

Total comments: 2

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -33 lines) Patch
M chrome/browser/referrer_policy_browsertest.cc View 17 chunks +54 lines, -29 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
plz review I'll fire of tryjobs once the blink side landed and rolled in.
6 years, 11 months ago (2014-01-08 14:57:42 UTC) #1
nasko
LGTM with one note. https://codereview.chromium.org/128173002/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/128173002/diff/1/content/renderer/render_view_impl.cc#newcode1965 content/renderer/render_view_impl.cc:1965: // would be nice if ...
6 years, 11 months ago (2014-01-08 17:11:08 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/128173002/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/128173002/diff/1/content/renderer/render_view_impl.cc#newcode1965 content/renderer/render_view_impl.cc:1965: // would be nice if we could get the ...
6 years, 11 months ago (2014-01-08 19:06:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/128173002/80001
6 years, 11 months ago (2014-01-10 05:15:48 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=210284
6 years, 11 months ago (2014-01-10 07:09:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/128173002/360001
6 years, 11 months ago (2014-01-10 09:02:00 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 11:02:30 UTC) #7
Message was sent while issue was closed.
Change committed as 244138

Powered by Google App Engine
This is Rietveld 408576698