Fixing SkPicture command pattern optimizations to make them work correctly with bounding box hierar…

src/core/SkRTree.cpp

Index: src/core/SkRTree.cpp
===================================================================
--- src/core/SkRTree.cpp	(revision 8135)
+++ src/core/SkRTree.cpp	(working copy)
@@ -434,6 +434,14 @@
     }
 }
 

[robertphillips, 2013/03/14 18:55:44]

What's going to happen in none deferred mode?

[Justin Novosad, 2013/03/14 20:04:14]

Then rewind optimizations will be illegal, and we will have to improve this
method.  That use case is not currently exercised by any of our test programs,
and RTree is not even used in production, so I see no point in investing effort
in that direction for now.

+void SkRTree::rewindInserts() {
+    SkASSERT(this->isEmpty()); // Currently only supports deferred inserts
+    while (!fDeferredInserts.isEmpty() &&
+           fClient->shouldRewind(fDeferredInserts.top().fChild.data)) {
+        fDeferredInserts.pop();
+    }
+}
+
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 
 static inline uint32_t get_area(const SkIRect& rect) {