Fixing SkPicture command pattern optimizations to make them work correctly with bounding box hierar…

src/core/SkTileGrid.cpp

 
 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkTileGrid.h"
 
@@ skipping 103 matching lines @@
 
 void SkTileGrid::clear() {
     for (int i = 0; i < fTileCount; i++) {
         fTileData[i].reset();
     }
 }
 
 int SkTileGrid::getCount() const {
     return fInsertionCount;
 }
+
+void SkTileGrid::rewindInserts() {
+    SkASSERT(fClient);

[robertphillips, 2013/03/14 18:55:44]

ouch - every tile.

[Justin Novosad, 2013/03/14 20:04:14]

You just gave me a good idea for a follow-up patch.  This method could receive a
bounds argument in order to only target the tiles affected by the rewound
commands.  I just filed a bug for it.
https://code.google.com/p/skia/issues/detail?id=1165

+    for (int i = 0; i < fTileCount; ++i) {
+        while (!fTileData[i].isEmpty() && fClient->shouldRewind(fTileData[i].top())) {
+            fTileData[i].pop();
+        }
+    }
+}