Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ppapi/tests/test_utils.h

Issue 12817009: Add Query() support to FileRef (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix yuzhu's concerns, fix tests Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ppapi/proxy/ppb_file_ref_proxy.cc ('K') | « ppapi/tests/test_file_ref.cc ('k') | ppapi/thunk/interfaces_ppb_public_stable.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_utils.h
diff --git a/ppapi/tests/test_utils.h b/ppapi/tests/test_utils.h
index e61efbddcd5a089422f1842a25e5e87b81397ae5..a67173a4efed1b3a4b760fcb4de24eec8b7a458e 100644
--- a/ppapi/tests/test_utils.h
+++ b/ppapi/tests/test_utils.h
@@ -190,7 +190,10 @@ class TestCompletionCallbackWithOutput : public TestCompletionCallback {
return GetCallbackWithOutput();
}
- const OutputT& output() { return output_storage_.output(); }
+ OutputT output() {
yzshen1 2013/03/21 21:06:31 I think this should be OutputT&.
+ return pp::internal::CallbackOutputTraits<OutputT>::StorageToPluginArg(
+ output_storage_);
+ }
typename pp::CompletionCallbackWithOutput<OutputT>::OutputStorageType
output_storage_;
« ppapi/proxy/ppb_file_ref_proxy.cc ('K') | « ppapi/tests/test_file_ref.cc ('k') | ppapi/thunk/interfaces_ppb_public_stable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698