tools/dom/src/WrappedList.dart - Issue 12817003: Change getRange to sublist. Make getRange deprecated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/src/WrappedList.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/lib/js_array.dart ('K') | « tests/standalone/io/zlib_test.dart ('k') | tools/dom/templates/html/impl/impl_Element.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/src/WrappedList.dart

diff --git a/tools/dom/src/WrappedList.dart b/tools/dom/src/WrappedList.dart

index b099526a9bb8c2d2ad1f389768b2cc52ccfffcc3..eb255ce5a5e84cc70588e9aa58bb25f3e48a6387 100644

--- a/tools/dom/src/WrappedList.dart

+++ b/tools/dom/src/WrappedList.dart

@@ -115,7 +115,9 @@ class _WrappedList<E> implements List<E> {

E removeLast() => _list.removeLast();

- List<E> getRange(int start, int length) => _list.getRange(start, length);

+ List<E> sublist(int start, [int end]) => _list.sublist(start, end);

+ List<E> getRange(int start, int length) => sublist(start, start + length);

void setRange(int start, int length, List<E> from, [int startFrom]) {

_list.setRange(start, length, from, startFrom);