tests/standalone/io/web_socket_protocol_processor_test.dart - Issue 12817003: Change getRange to sublist. Make getRange deprecated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/standalone/io/web_socket_protocol_processor_test.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/lib/js_array.dart ('K') | « tests/standalone/io/mime_multipart_parser_test.dart ('k') | tests/standalone/io/zlib_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/standalone/io/web_socket_protocol_processor_test.dart

diff --git a/tests/standalone/io/web_socket_protocol_processor_test.dart b/tests/standalone/io/web_socket_protocol_processor_test.dart

index 090d34575713d31d5a6c3bf5413222ced9e230a8..1490e711513cceb757891098bf4951bfe46aa397 100644

--- a/tests/standalone/io/web_socket_protocol_processor_test.dart

+++ b/tests/standalone/io/web_socket_protocol_processor_test.dart

@@ -120,7 +120,7 @@ void testFullMessages() {

// Update the transformer one byte at the time.

messageCount++;

for (int i = 0; i < frame.length; i++) {

- controller.add(frame.getRange(i, 1));

+ controller.add(<int>[frame[i]]);

}

Expect.equals(0, transformer._state);

Expect.isNotNull(mc.data);

@@ -129,7 +129,7 @@ void testFullMessages() {

// Update the transformer two bytes at the time.

messageCount++;

for (int i = 0; i < frame.length; i += 2) {

- controller.add(frame.getRange(i, i + 1 < frame.length ? 2 : 1));

+ controller.add(frame.sublist(i, min(i + 2, frame.length)));

}

Expect.equals(0, transformer._state);

Expect.isNotNull(mc.data);