Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: tests/standalone/io/http_parser_test.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/http_parser_test.dart
diff --git a/tests/standalone/io/http_parser_test.dart b/tests/standalone/io/http_parser_test.dart
index ab0220630653d028e63f9769762eb7f538d27b46..cc4cc4d2d9a46e566a9411590013c306efb9ebaa 100644
--- a/tests/standalone/io/http_parser_test.dart
+++ b/tests/standalone/io/http_parser_test.dart
@@ -116,9 +116,8 @@ class HttpParserTest {
if (chunkSize == -1) chunkSize = requestData.length;
reset();
for (int pos = 0; pos < requestData.length; pos += chunkSize) {
- int remaining = requestData.length - pos;
- int writeLength = min(chunkSize, remaining);
- controller.add(requestData.getRange(pos, writeLength));
+ int end = min(requestData.length, pos + chunkSize);
+ controller.add(requestData.sublist(pos, end));
}
controller.close();
}
@@ -160,9 +159,8 @@ class HttpParserTest {
for (int pos = 0;
pos < requestData.length && !errorCalled;
pos += chunkSize) {
- int remaining = requestData.length - pos;
- int writeLength = min(chunkSize, remaining);
- controller.add(requestData.getRange(pos, writeLength));
+ int end = min(requestData.length, pos + chunkSize);
+ controller.add(requestData.sublist(pos, end));
}
controller.close();
}
@@ -260,9 +258,8 @@ class HttpParserTest {
if (chunkSize == -1) chunkSize = requestData.length;
reset();
for (int pos = 0; pos < requestData.length; pos += chunkSize) {
- int remaining = requestData.length - pos;
- int writeLength = min(chunkSize, remaining);
- controller.add(requestData.getRange(pos, writeLength));
+ int end = min(requestData.length, pos + chunkSize);
+ controller.add(requestData.sublist(pos, end));
}
if (close) controller.close();
@@ -311,9 +308,8 @@ class HttpParserTest {
for (int pos = 0;
pos < requestData.length && !errorCalled;
pos += chunkSize) {
- int remaining = requestData.length - pos;
- int writeLength = min(chunkSize, remaining);
- controller.add(requestData.getRange(pos, writeLength));
+ int end = min(requestData.length, pos + chunkSize);
+ controller.add(requestData.sublist(pos, end));
}
controller.close();
}

Powered by Google App Engine
This is Rietveld 408576698