sdk/lib/web_sql/dartium/web_sql_dartium.dart - Issue 12817003: Change getRange to sublist. Make getRange deprecated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/web_sql/dartium/web_sql_dartium.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/lib/js_array.dart ('K') | « sdk/lib/web_sql/dart2js/web_sql_dart2js.dart ('k') | tests/co19/co19-dart2dart.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/web_sql/dartium/web_sql_dartium.dart

diff --git a/sdk/lib/web_sql/dartium/web_sql_dartium.dart b/sdk/lib/web_sql/dartium/web_sql_dartium.dart

index 945ed1ee160a562ba73f7b1d73c33b8454628d21..e984c16f07107336396c3af84ca08c54fbf47e6d 100644

--- a/sdk/lib/web_sql/dartium/web_sql_dartium.dart

+++ b/sdk/lib/web_sql/dartium/web_sql_dartium.dart

@@ -449,8 +449,13 @@ class SqlResultSetRowList extends NativeFieldWrapperClass1 implements List<Map>

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<Map> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <Map>[]);

+ }

List<Map> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <Map>[]);

+ sublist(start, start + rangeLength);

Map<int, Map> asMap() =>

IterableMixinWorkaround.asMapList(this);