sdk/lib/io/secure_socket.dart - Issue 12817003: Change getRange to sublist. Make getRange deprecated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/secure_socket.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/io/secure_socket.dart

diff --git a/sdk/lib/io/secure_socket.dart b/sdk/lib/io/secure_socket.dart

index 727f0198f4c522f71019f6eb409eb2d26733738e..41fdf59a81d0a1c8e77f8432e5a925d4c7978167 100644

--- a/sdk/lib/io/secure_socket.dart

+++ b/sdk/lib/io/secure_socket.dart

@@ -433,7 +433,7 @@ class _RawSecureSocket extends Stream<RawSocketEvent>

}

List<int> result = (toRead == 0) ? null :

- buffer.data.getRange(buffer.start, toRead);

+ buffer.data.sublist(buffer.start, buffer.start + toRead);

buffer.advanceStart(toRead);

// Set up a read event if the filter still has data.

« sdk/lib/_internal/compiler/implementation/lib/js_array.dart ('K') | « sdk/lib/io/options.dart ('k') | sdk/lib/io/websocket_impl.dart » ('j') | no next file with comments »