Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/tracer.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/tracer.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/tracer.dart b/sdk/lib/_internal/compiler/implementation/ssa/tracer.dart
index fd4884cdee7b491f8610328bb6fd79fc50272bf0..b2d7a070d9574b7961cb2fbe88420731709914bb 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/tracer.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/tracer.dart
@@ -348,8 +348,7 @@ class HInstructionStringifier implements HVisitor<String> {
String name = invoke.selector.name.slowToString();
String target = "($kind) $receiver.$name";
int offset = HInvoke.ARGUMENTS_OFFSET;
- List arguments =
- invoke.inputs.getRange(offset, invoke.inputs.length - offset);
+ List arguments = invoke.inputs.sublist(offset);
return visitGenericInvoke("Invoke", target, arguments);
}
@@ -363,16 +362,14 @@ class HInstructionStringifier implements HVisitor<String> {
String visitInvokeStatic(HInvokeStatic invoke) {
String target = temporaryId(invoke.target);
int offset = HInvoke.ARGUMENTS_OFFSET;
- List arguments =
- invoke.inputs.getRange(offset, invoke.inputs.length - offset);
+ List arguments = invoke.inputs.sublist(offset);
return visitGenericInvoke("Invoke", target, arguments);
}
String visitInvokeSuper(HInvokeSuper invoke) {
String target = temporaryId(invoke.target);
int offset = HInvoke.ARGUMENTS_OFFSET + 1;
- List arguments =
- invoke.inputs.getRange(offset, invoke.inputs.length - offset);
+ List arguments = invoke.inputs.sublist(offset);
return visitGenericInvoke("Invoke super", target, arguments);
}

Powered by Google App Engine
This is Rietveld 408576698