sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart - Issue 12817003: Change getRange to sublist. Make getRange deprecated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/lib/simd128.dart ('K') | « sdk/lib/_internal/compiler/implementation/dart2js.dart ('k') | sdk/lib/_internal/compiler/implementation/lib/js_array.dart » ('j') | sdk/lib/_internal/compiler/implementation/lib/js_array.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

index bf9f5c088814b59b949345163d2c20e7b7ade3c0..838c7a826dba0706721397d21aee9a5645113269 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

@@ -227,11 +227,11 @@ function(cls, desc) {

if (isInterceptedMethod) {

receiver = argumentsBuffer[0];

- arguments = argumentsBuffer.getRange(1,

- indexOfLastOptionalArgumentInParameters);

+ arguments = argumentsBuffer.sublist(1,

+ indexOfLastOptionalArgumentInParameters + 1);

} else {

receiver = new jsAst.VariableUse('this');

- arguments = argumentsBuffer.getRange(0,

+ arguments = argumentsBuffer.sublist(0,

indexOfLastOptionalArgumentInParameters + 1);

}