Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/tests/vm/dart/byte_array_optimized_test.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/lib/simd128.dart ('K') | « runtime/lib/typeddata.dart ('k') | runtime/tests/vm/dart/byte_array_test.dart » ('j') | sdk/lib/_internal/compiler/implementation/lib/js_array.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/tests/vm/dart/byte_array_optimized_test.dart
diff --git a/runtime/tests/vm/dart/byte_array_optimized_test.dart b/runtime/tests/vm/dart/byte_array_optimized_test.dart
index 803944d92de8e6501ccdd63c21172e042dcc810f..e645c733d9fa514fb8e56eb32f8756eb459271c0 100644
--- a/runtime/tests/vm/dart/byte_array_optimized_test.dart
+++ b/runtime/tests/vm/dart/byte_array_optimized_test.dart
@@ -75,14 +75,14 @@ class OptimizedByteArrayTest {
for (int i = 0; i < array.length; ++i) {
array[i] = i;
}
- var copy = array.getRange(0, array.length);
+ var copy = array.sublist(0, array.length);
Expect.isFalse(copy === array);
Expect.isTrue(copy is Int8List);
Expect.equals(10, copy.length);
Expect.listEquals(array, copy);
- var empty = array.getRange(array.length, 0);
+ var empty = array.sublist(array.length, array.length);
Expect.equals(0, empty.length);
- var region = array.getRange(3, array.length - 6);
+ var region = array.sublist(3, array.length - 3);
Expect.isTrue(copy is Int8List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -150,14 +150,14 @@ class OptimizedByteArrayTest {
for (int i = 0; i < array.length; ++i) {
array[i] = i;
}
- var copy = array.getRange(0, array.length);
+ var copy = array.sublist(0, array.length);
Expect.isFalse(copy === array);
Expect.isTrue(copy is Uint8List);
Expect.equals(10, copy.length);
Expect.listEquals(array, copy);
- var empty = array.getRange(array.length, 0);
+ var empty = array.sublist(array.length, array.length);
Expect.equals(0, empty.length);
- var region = array.getRange(3, array.length - 6);
+ var region = array.sublist(3, array.length - 3);
Expect.isTrue(copy is Uint8List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -238,14 +238,14 @@ class OptimizedByteArrayTest {
for (int i = 0; i < array.length; ++i) {
array[i] = i;
}
- var copy = array.getRange(0, array.length);
+ var copy = array.sublist(0, array.length);
Expect.isFalse(copy === array);
Expect.isTrue(copy is Int16List);
Expect.equals(10, copy.length);
Expect.listEquals(array, copy);
- var empty = array.getRange(array.length, 0);
+ var empty = array.sublist(array.length, array.length);
Expect.equals(0, empty.length);
- var region = array.getRange(3, array.length - 6);
+ var region = array.sublist(3, array.length - 3);
Expect.isTrue(copy is Int16List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -314,14 +314,14 @@ class OptimizedByteArrayTest {
for (int i = 0; i < array.length; ++i) {
array[i] = i;
}
- var copy = array.getRange(0, array.length);
+ var copy = array.sublist(0, array.length);
Expect.isFalse(copy === array);
Expect.isTrue(copy is Uint16List);
Expect.equals(10, copy.length);
Expect.listEquals(array, copy);
- var empty = array.getRange(array.length, 0);
+ var empty = array.sublist(array.length, array.length);
Expect.equals(0, empty.length);
- var region = array.getRange(3, array.length - 6);
+ var region = array.sublist(3, array.length - 3);
Expect.isTrue(copy is Uint16List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -408,14 +408,14 @@ class OptimizedByteArrayTest {
for (int i = 0; i < array.length; ++i) {
array[i] = i;
}
- var copy = array.getRange(0, array.length);
+ var copy = array.sublist(0, array.length);
Expect.isFalse(copy === array);
Expect.isTrue(copy is Int32List);
Expect.equals(10, copy.length);
Expect.listEquals(array, copy);
- var empty = array.getRange(array.length, 0);
+ var empty = array.sublist(array.length, array.length);
Expect.equals(0, empty.length);
- var region = array.getRange(3, array.length - 6);
+ var region = array.sublist(3, array.length - 3);
Expect.isTrue(copy is Int32List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -487,14 +487,14 @@ class OptimizedByteArrayTest {
for (int i = 0; i < array.length; ++i) {
array[i] = i;
}
- var copy = array.getRange(0, array.length);
+ var copy = array.sublist(0, array.length);
Expect.isFalse(copy === array);
Expect.isTrue(copy is Uint32List);
Expect.equals(10, copy.length);
Expect.listEquals(array, copy);
- var empty = array.getRange(array.length, 0);
+ var empty = array.sublist(array.length, array.length);
Expect.equals(0, empty.length);
- var region = array.getRange(3, array.length - 6);
+ var region = array.sublist(3, array.length - 3);
Expect.isTrue(copy is Uint32List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -510,7 +510,7 @@ class OptimizedByteArrayTest {
(e) { return e is ArgumentError; });
var array = new Uint32List(10);
testUint32ListImpl(array);
-
+
}
static testInt64ListImpl(Int64List array) {
@@ -584,14 +584,14 @@ class OptimizedByteArrayTest {
for (int i = 0; i < array.length; ++i) {
array[i] = i;
}
- var copy = array.getRange(0, array.length);
+ var copy = array.sublist(0, array.length);
Expect.isFalse(copy === array);
Expect.isTrue(copy is Int64List);
Expect.equals(10, copy.length);
Expect.listEquals(array, copy);
- var empty = array.getRange(array.length, 0);
+ var empty = array.sublist(array.length, array.length);
Expect.equals(0, empty.length);
- var region = array.getRange(3, array.length - 6);
+ var region = array.sublist(3, array.length - 3);
Expect.isTrue(copy is Int64List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -664,14 +664,14 @@ class OptimizedByteArrayTest {
for (int i = 0; i < array.length; ++i) {
array[i] = i;
}
- var copy = array.getRange(0, array.length);
+ var copy = array.sublist(0, array.length);
Expect.isFalse(copy === array);
Expect.isTrue(copy is Uint64List);
Expect.equals(10, copy.length);
Expect.listEquals(array, copy);
- var empty = array.getRange(array.length, 0);
+ var empty = array.sublist(array.length, array.length);
Expect.equals(0, empty.length);
- var region = array.getRange(3, array.length - 6);
+ var region = array.sublist(3, array.length - 3);
Expect.isTrue(copy is Uint64List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -729,14 +729,14 @@ class OptimizedByteArrayTest {
for (int i = 0; i < array.length; ++i) {
array[i] = i * 1.0;
}
- var copy = array.getRange(0, array.length);
+ var copy = array.sublist(0, array.length);
Expect.isFalse(copy === array);
Expect.isTrue(copy is Float32List);
Expect.equals(10, copy.length);
Expect.listEquals(array, copy);
- var empty = array.getRange(array.length, 0);
+ var empty = array.sublist(array.length, array.length);
Expect.equals(0, empty.length);
- var region = array.getRange(3, array.length - 6);
+ var region = array.sublist(3, array.length - 3);
Expect.isTrue(copy is Float32List);
Expect.equals(4, region.length);
Expect.listEquals([3.0, 4.0, 5.0, 6.0], region);
@@ -795,14 +795,14 @@ class OptimizedByteArrayTest {
for (int i = 0; i < array.length; ++i) {
array[i] = i * 1.0;
}
- var copy = array.getRange(0, array.length);
+ var copy = array.sublist(0, array.length);
Expect.isFalse(copy === array);
Expect.isTrue(copy is Float64List);
Expect.equals(10, copy.length);
Expect.listEquals(array, copy);
- var empty = array.getRange(array.length, 0);
+ var empty = array.sublist(array.length, array.length);
Expect.equals(0, empty.length);
- var region = array.getRange(3, array.length - 6);
+ var region = array.sublist(3, array.length - 3);
Expect.isTrue(copy is Float64List);
Expect.equals(4, region.length);
Expect.listEquals([3.0, 4.0, 5.0, 6.0], region);
@@ -929,12 +929,12 @@ class OptimizedByteArrayTest {
for (int i = 0; i < view.length; ++i) {
view[i] = i;
}
- var copy = view.getRange(0, view.length);
+ var copy = view.sublist(0, view.length);
Expect.isFalse(copy === view);
Expect.isTrue(copy is Int8List);
Expect.equals(10, copy.length);
Expect.listEquals(view, copy);
- var region = view.getRange(3, view.length - 6);
+ var region = view.sublist(3, view.length - 3);
Expect.isTrue(copy is Int8List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -1042,12 +1042,12 @@ class OptimizedByteArrayTest {
for (int i = 0; i < view.length; ++i) {
view[i] = i;
}
- var copy = view.getRange(0, view.length);
+ var copy = view.sublist(0, view.length);
Expect.isFalse(copy === view);
Expect.isTrue(copy is Uint8List);
Expect.equals(10, copy.length);
Expect.listEquals(view, copy);
- var region = view.getRange(3, view.length - 6);
+ var region = view.sublist(3, view.length - 3);
Expect.isTrue(copy is Uint8List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -1176,12 +1176,12 @@ class OptimizedByteArrayTest {
for (int i = 0; i < view.length; ++i) {
view[i] = i;
}
- var copy = view.getRange(0, view.length);
+ var copy = view.sublist(0, view.length);
Expect.isFalse(copy === view);
Expect.isTrue(copy is Int16List);
Expect.equals(10, copy.length);
Expect.listEquals(view, copy);
- var region = view.getRange(3, view.length - 6);
+ var region = view.sublist(3, view.length - 3);
Expect.isTrue(copy is Int16List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -1293,12 +1293,12 @@ class OptimizedByteArrayTest {
for (int i = 0; i < view.length; ++i) {
view[i] = i;
}
- var copy = view.getRange(0, view.length);
+ var copy = view.sublist(0, view.length);
Expect.isFalse(copy === view);
Expect.isTrue(copy is Uint16List);
Expect.equals(10, copy.length);
Expect.listEquals(view, copy);
- var region = view.getRange(3, view.length - 6);
+ var region = view.sublist(3, view.length - 3);
Expect.isTrue(copy is Uint16List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -1453,12 +1453,12 @@ class OptimizedByteArrayTest {
for (int i = 0; i < view.length; ++i) {
view[i] = i;
}
- var copy = view.getRange(0, view.length);
+ var copy = view.sublist(0, view.length);
Expect.isFalse(copy === view);
Expect.isTrue(copy is Int32List);
Expect.equals(10, copy.length);
Expect.listEquals(view, copy);
- var region = view.getRange(3, view.length - 6);
+ var region = view.sublist(3, view.length - 3);
Expect.isTrue(copy is Int32List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -1582,12 +1582,12 @@ class OptimizedByteArrayTest {
for (int i = 0; i < view.length; ++i) {
view[i] = i;
}
- var copy = view.getRange(0, view.length);
+ var copy = view.sublist(0, view.length);
Expect.isFalse(copy === view);
Expect.isTrue(copy is Uint32List);
Expect.equals(10, copy.length);
Expect.listEquals(view, copy);
- var region = view.getRange(3, view.length - 6);
+ var region = view.sublist(3, view.length - 3);
Expect.isTrue(copy is Uint32List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -1774,12 +1774,12 @@ class OptimizedByteArrayTest {
for (int i = 0; i < view.length; ++i) {
view[i] = i;
}
- var copy = view.getRange(0, view.length);
+ var copy = view.sublist(0, view.length);
Expect.isFalse(copy === view);
Expect.isTrue(copy is Int64List);
Expect.equals(10, copy.length);
Expect.listEquals(view, copy);
- var region = view.getRange(3, view.length - 6);
+ var region = view.sublist(3, view.length - 3);
Expect.isTrue(copy is Int64List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -1936,12 +1936,12 @@ class OptimizedByteArrayTest {
for (int i = 0; i < view.length; ++i) {
view[i] = i;
}
- var copy = view.getRange(0, view.length);
+ var copy = view.sublist(0, view.length);
Expect.isFalse(copy === view);
Expect.isTrue(copy is Uint64List);
Expect.equals(10, copy.length);
Expect.listEquals(view, copy);
- var region = view.getRange(3, view.length - 6);
+ var region = view.sublist(3, view.length - 3);
Expect.isTrue(copy is Uint64List);
Expect.equals(4, region.length);
Expect.listEquals([3, 4, 5, 6], region);
@@ -2048,12 +2048,12 @@ class OptimizedByteArrayTest {
for (int i = 0; i < view.length; ++i) {
view[i] = i * 1.0;
}
- var copy = view.getRange(0, view.length);
+ var copy = view.sublist(0, view.length);
Expect.isFalse(copy === view);
Expect.isTrue(copy is Float32List);
Expect.equals(10, copy.length);
Expect.listEquals(view, copy);
- var region = view.getRange(3, view.length - 6);
+ var region = view.sublist(3, view.length - 3);
Expect.isTrue(copy is Float32List);
Expect.equals(4, region.length);
Expect.listEquals([3.0, 4.0, 5.0, 6.0], region);
@@ -2155,12 +2155,12 @@ class OptimizedByteArrayTest {
for (int i = 0; i < view.length; ++i) {
view[i] = i * 1.0;
}
- var copy = view.getRange(0, view.length);
+ var copy = view.sublist(0, view.length);
Expect.isFalse(copy === view);
Expect.isTrue(copy is Float64List);
Expect.equals(10, copy.length);
Expect.listEquals(view, copy);
- var region = view.getRange(3, view.length - 6);
+ var region = view.sublist(3, view.length - 3);
Expect.isTrue(copy is Float64List);
Expect.equals(4, region.length);
Expect.listEquals([3.0, 4.0, 5.0, 6.0], region);
« runtime/lib/simd128.dart ('K') | « runtime/lib/typeddata.dart ('k') | runtime/tests/vm/dart/byte_array_test.dart » ('j') | sdk/lib/_internal/compiler/implementation/lib/js_array.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698