pkg/scheduled_test/lib/src/descriptor/directory.dart - Issue 12817003: Change getRange to sublist. Make getRange deprecated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/scheduled_test/lib/src/descriptor/directory.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/scheduled_test/lib/src/descriptor/directory.dart

diff --git a/pkg/scheduled_test/lib/src/descriptor/directory.dart b/pkg/scheduled_test/lib/src/descriptor/directory.dart

index 3d04816c966be034e48808eee5174e44c6af1a1a..594fb56c27d220f48efead09095b37b06de11eef 100644

--- a/pkg/scheduled_test/lib/src/descriptor/directory.dart

+++ b/pkg/scheduled_test/lib/src/descriptor/directory.dart

@@ -62,7 +62,7 @@ class Directory extends descriptor.Entry {

throw "Found multiple entries named '${split.first}' within "

"$nameDescription.";

} else {

- var remainingPath = split.getRange(1, split.length - 1);

+ var remainingPath = split.sublist(1);

if (remainingPath.isEmpty) {

return matchingEntries.first.read();

} else {

« no previous file with comments | « pkg/intl/test/date_time_format_test_core.dart ('k') | runtime/lib/array.dart » ('j') | runtime/lib/array.dart » ('J')