sdk/lib/html/dartium/html_dartium.dart - Issue 12817003: Change getRange to sublist. Make getRange deprecated.

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: sdk/lib/html/dartium/html_dartium.dart

diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart

index b1165f68342d888f1f8f06e1ff264af15a00341a..63d206252078f7db9409d6630c8a71c268c9d2d8 100644

--- a/sdk/lib/html/dartium/html_dartium.dart

+++ b/sdk/lib/html/dartium/html_dartium.dart

@@ -7973,8 +7973,13 @@ class DomMimeTypeArray extends NativeFieldWrapperClass1 implements List<DomMimeT

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<DomMimeType> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <DomMimeType>[]);

+ }

List<DomMimeType> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <DomMimeType>[]);

+ sublist(start, start + rangeLength);

Map<int, DomMimeType> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -8246,8 +8251,13 @@ class DomPluginArray extends NativeFieldWrapperClass1 implements List<DomPlugin>

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<DomPlugin> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <DomPlugin>[]);

+ }

List<DomPlugin> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <DomPlugin>[]);

+ sublist(start, start + rangeLength);

Map<int, DomPlugin> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -8637,8 +8647,13 @@ class DomStringList extends NativeFieldWrapperClass1 implements List<String> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<String> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <String>[]);

+ }

List<String> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <String>[]);

+ sublist(start, start + rangeLength);

Map<int, String> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -8913,9 +8928,13 @@ class _ChildrenElementList implements List {

throw new UnimplementedError();

}

+ List sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return new _FrozenElementList._wrap(Lists.getRange(this, start, end, []));

+ }

List getRange(int start, int rangeLength) =>

- new _FrozenElementList._wrap(Lists.getRange(this, start, rangeLength,

- []));

+ sublist(start, start + rangeLength);

int indexOf(Element element, [int start = 0]) {

return Lists.indexOf(this, element, start, this.length);

@@ -9123,8 +9142,12 @@ class _FrozenElementList implements List {

throw new UnsupportedError('');

}

+ List<Element> sublist(int start, [int end]) {

+ return new _FrozenElementList._wrap(_nodeList.sublist(start, end));

+ }

List<Element> getRange(int start, int rangeLength) =>

- new _FrozenElementList._wrap(_nodeList.getRange(start, rangeLength));

+ sublist(start, start + rangeLength);

int indexOf(Element element, [int start = 0]) =>

_nodeList.indexOf(element, start);

@@ -11637,8 +11660,13 @@ class FileList extends NativeFieldWrapperClass1 implements List<File> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<File> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <File>[]);

+ }

List<File> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <File>[]);

+ sublist(start, start + rangeLength);

Map<int, File> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -12253,8 +12281,13 @@ class Float32Array extends ArrayBufferView implements List<num> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<num> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <num>[]);

+ }

List<num> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <num>[]);

+ sublist(start, start + rangeLength);

Map<int, num> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -12493,8 +12526,13 @@ class Float64Array extends ArrayBufferView implements List<num> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<num> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <num>[]);

+ }

List<num> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <num>[]);

+ sublist(start, start + rangeLength);

Map<int, num> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -13182,8 +13220,13 @@ class HtmlAllCollection extends NativeFieldWrapperClass1 implements List<Node> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<Node> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <Node>[]);

+ }

List<Node> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <Node>[]);

+ sublist(start, start + rangeLength);

Map<int, Node> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -13396,8 +13439,13 @@ class HtmlCollection extends NativeFieldWrapperClass1 implements List<Node> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<Node> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <Node>[]);

+ }

List<Node> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <Node>[]);

+ sublist(start, start + rangeLength);

Map<int, Node> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -15721,8 +15769,13 @@ class Int16Array extends ArrayBufferView implements List<int> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<int> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <int>[]);

+ }

List<int> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <int>[]);

+ sublist(start, start + rangeLength);

Map<int, int> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -15961,8 +16014,13 @@ class Int32Array extends ArrayBufferView implements List<int> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<int> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <int>[]);

+ }

List<int> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <int>[]);

+ sublist(start, start + rangeLength);

Map<int, int> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -16201,8 +16259,13 @@ class Int8Array extends ArrayBufferView implements List<int> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<int> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <int>[]);

+ }

List<int> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <int>[]);

+ sublist(start, start + rangeLength);

Map<int, int> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -18975,8 +19038,13 @@ class _ChildNodeListLazy implements List {

throw new UnsupportedError(

"Cannot insertRange on immutable List.");

}

+ List<Node> sublist(int start, [int end]) {

+ if (end == null) end == length;

+ return Lists.getRange(this, start, end, <Node>[]);

+ }

List<Node> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <Node>[]);

+ sublist(start, start + rangeLength);

// -- end List<Node> mixins.

@@ -19452,8 +19520,13 @@ class NodeList extends NativeFieldWrapperClass1 implements List<Node> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<Node> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <Node>[]);

+ }

List<Node> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <Node>[]);

+ sublist(start, start + rangeLength);

Map<int, Node> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -22151,8 +22224,13 @@ class SourceBufferList extends EventTarget implements List<SourceBuffer> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<SourceBuffer> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <SourceBuffer>[]);

+ }

List<SourceBuffer> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <SourceBuffer>[]);

+ sublist(start, start + rangeLength);

Map<int, SourceBuffer> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -22474,8 +22552,13 @@ class SpeechGrammarList extends NativeFieldWrapperClass1 implements List<SpeechG

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<SpeechGrammar> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <SpeechGrammar>[]);

+ }

List<SpeechGrammar> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <SpeechGrammar>[]);

+ sublist(start, start + rangeLength);

Map<int, SpeechGrammar> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -24162,8 +24245,13 @@ class TextTrackCueList extends NativeFieldWrapperClass1 implements List<TextTrac

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<TextTrackCue> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <TextTrackCue>[]);

+ }

List<TextTrackCue> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <TextTrackCue>[]);

+ sublist(start, start + rangeLength);

Map<int, TextTrackCue> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -24376,8 +24464,13 @@ class TextTrackList extends EventTarget implements List<TextTrack> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<TextTrack> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <TextTrack>[]);

+ }

List<TextTrack> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <TextTrack>[]);

+ sublist(start, start + rangeLength);

Map<int, TextTrack> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -24807,8 +24900,13 @@ class TouchList extends NativeFieldWrapperClass1 implements List<Touch> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<Touch> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <Touch>[]);

+ }

List<Touch> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <Touch>[]);

+ sublist(start, start + rangeLength);

Map<int, Touch> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -25321,8 +25419,13 @@ class Uint16Array extends ArrayBufferView implements List<int> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<int> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <int>[]);

+ }

List<int> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <int>[]);

+ sublist(start, start + rangeLength);

Map<int, int> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -25561,8 +25664,13 @@ class Uint32Array extends ArrayBufferView implements List<int> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<int> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <int>[]);

+ }

List<int> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <int>[]);

+ sublist(start, start + rangeLength);

Map<int, int> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -25801,8 +25909,13 @@ class Uint8Array extends ArrayBufferView implements List<int> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<int> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <int>[]);

+ }

List<int> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <int>[]);

+ sublist(start, start + rangeLength);

Map<int, int> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -26039,8 +26152,13 @@ class Uint8ClampedArray extends Uint8Array implements List<int> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<int> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <int>[]);

+ }

List<int> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <int>[]);

+ sublist(start, start + rangeLength);

Map<int, int> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -29891,8 +30009,13 @@ class _ClientRectList extends NativeFieldWrapperClass1 implements List<Rect> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<Rect> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <Rect>[]);

+ }

List<Rect> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <Rect>[]);

+ sublist(start, start + rangeLength);

Map<int, Rect> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -30097,8 +30220,13 @@ class _CssRuleList extends NativeFieldWrapperClass1 implements List<CssRule> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<CssRule> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <CssRule>[]);

+ }

List<CssRule> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <CssRule>[]);

+ sublist(start, start + rangeLength);

Map<int, CssRule> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -30303,8 +30431,13 @@ class _CssValueList extends CssValue implements List<CssValue> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<CssValue> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <CssValue>[]);

+ }

List<CssValue> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <CssValue>[]);

+ sublist(start, start + rangeLength);

Map<int, CssValue> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -30652,8 +30785,13 @@ class _EntryArray extends NativeFieldWrapperClass1 implements List<Entry> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<Entry> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <Entry>[]);

+ }

List<Entry> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <Entry>[]);

+ sublist(start, start + rangeLength);

Map<int, Entry> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -30858,8 +30996,13 @@ class _EntryArraySync extends NativeFieldWrapperClass1 implements List<EntrySync

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<EntrySync> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <EntrySync>[]);

+ }

List<EntrySync> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <EntrySync>[]);

+ sublist(start, start + rangeLength);

Map<int, EntrySync> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -31064,8 +31207,13 @@ class _GamepadList extends NativeFieldWrapperClass1 implements List<Gamepad> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<Gamepad> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <Gamepad>[]);

+ }

List<Gamepad> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <Gamepad>[]);

+ sublist(start, start + rangeLength);

Map<int, Gamepad> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -31361,8 +31509,13 @@ class _NamedNodeMap extends NativeFieldWrapperClass1 implements List<Node> {

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<Node> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <Node>[]);

+ }

List<Node> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <Node>[]);

+ sublist(start, start + rangeLength);

Map<int, Node> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -31591,8 +31744,13 @@ class _SpeechInputResultList extends NativeFieldWrapperClass1 implements List<Sp

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<SpeechInputResult> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <SpeechInputResult>[]);

+ }

List<SpeechInputResult> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <SpeechInputResult>[]);

+ sublist(start, start + rangeLength);

Map<int, SpeechInputResult> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -31797,8 +31955,13 @@ class _SpeechRecognitionResultList extends NativeFieldWrapperClass1 implements L

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<SpeechRecognitionResult> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <SpeechRecognitionResult>[]);

+ }

List<SpeechRecognitionResult> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <SpeechRecognitionResult>[]);

+ sublist(start, start + rangeLength);

Map<int, SpeechRecognitionResult> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -32003,8 +32166,13 @@ class _StyleSheetList extends NativeFieldWrapperClass1 implements List<StyleShee

throw new UnsupportedError("Cannot insertRange on immutable List.");

}

+ List<StyleSheet> sublist(int start, [int end]) {

+ if (end == null) end = length;

+ return Lists.getRange(this, start, end, <StyleSheet>[]);

+ }

List<StyleSheet> getRange(int start, int rangeLength) =>

- Lists.getRange(this, start, rangeLength, <StyleSheet>[]);

+ sublist(start, start + rangeLength);

Map<int, StyleSheet> asMap() =>

IterableMixinWorkaround.asMapList(this);

@@ -34279,7 +34447,9 @@ class _WrappedList<E> implements List<E> {

E removeLast() => _list.removeLast();

- List<E> getRange(int start, int length) => _list.getRange(start, length);

+ List<E> sublist(int start, [int end]) => _list.sublist(start, end);

+ List<E> getRange(int start, int length) => sublist(start, start + length);

void setRange(int start, int length, List<E> from, [int startFrom]) {

_list.setRange(start, length, from, startFrom);

« sdk/lib/core/list.dart ('K') | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/html/html_common/filtered_element_list.dart » ('j') | tools/testing/dart/http_server.dart » ('J')