runtime/tests/vm/dart/byte_array_test.dart - Issue 12817003: Change getRange to sublist. Make getRange deprecated.

Unified Diff: runtime/tests/vm/dart/byte_array_test.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/tests/vm/dart/byte_array_test.dart

diff --git a/runtime/tests/vm/dart/byte_array_test.dart b/runtime/tests/vm/dart/byte_array_test.dart

index 0eab243cd0d6b2e2c541abfc06571c0400ecc652..f63cb321796e710cb2bab30ca5464f6a64680630 100644

--- a/runtime/tests/vm/dart/byte_array_test.dart

+++ b/runtime/tests/vm/dart/byte_array_test.dart

@@ -73,14 +73,14 @@ class ByteArrayTest {

for (int i = 0; i < array.length; ++i) {

array[i] = i;

}

- var copy = array.getRange(0, array.length);

+ var copy = array.sublist(0, array.length);

Expect.isFalse(copy === array);

Expect.isTrue(copy is Int8List);

Expect.equals(10, copy.length);

Expect.listEquals(array, copy);

- var empty = array.getRange(array.length, 0);

+ var empty = array.sublist(array.length, array.length);

floitsch 2013/03/14 15:46:06 you could also copy paste this line and remove the

Lasse Reichstein Nielsen 2013/03/15 09:13:09 Done.

Expect.equals(0, empty.length);

- var region = array.getRange(3, array.length - 6);

+ var region = array.sublist(3, array.length - 3);

Expect.isTrue(copy is Int8List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -92,7 +92,7 @@ class ByteArrayTest {

Expect.throws(() { new Int8List(-1); },

(e) { return e is ArgumentError; });

Expect.throws(() { new Int8List.transferable(-1); },

- (e) { return e is ArgumentError; });

+ (e) { return e is ArgumentError; });

var array = new Int8List(10);

testInt8ListImpl(array);

array = new Int8List.transferable(10);

@@ -152,14 +152,14 @@ class ByteArrayTest {

for (int i = 0; i < array.length; ++i) {

array[i] = i;

}

- var copy = array.getRange(0, array.length);

+ var copy = array.sublist(0, array.length);

Expect.isFalse(copy === array);

Expect.isTrue(copy is Uint8List);

Expect.equals(10, copy.length);

Expect.listEquals(array, copy);

- var empty = array.getRange(array.length, 0);

+ var empty = array.sublist(array.length, array.length);

Expect.equals(0, empty.length);

- var region = array.getRange(3, array.length - 6);

+ var region = array.sublist(3, array.length - 3);

Expect.isTrue(copy is Uint8List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -229,14 +229,14 @@ class ByteArrayTest {

for (int i = 0; i < array.length; ++i) {

array[i] = i;

}

- var copy = array.getRange(0, array.length);

+ var copy = array.sublist(0, array.length);

Expect.isFalse(copy === array);

Expect.isTrue(copy is Uint8ClampedList);

Expect.equals(10, copy.length);

Expect.listEquals(array, copy);

- var empty = array.getRange(array.length, 0);

+ var empty = array.sublist(array.length, array.length);

Expect.equals(0, empty.length);

- var region = array.getRange(3, array.length - 6);

+ var region = array.sublist(3, array.length - 3);

Expect.isTrue(copy is Uint8ClampedList);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -320,14 +320,14 @@ class ByteArrayTest {

for (int i = 0; i < array.length; ++i) {

array[i] = i;

}

- var copy = array.getRange(0, array.length);

+ var copy = array.sublist(0, array.length);

Expect.isFalse(copy === array);

Expect.isTrue(copy is Int16List);

Expect.equals(10, copy.length);

Expect.listEquals(array, copy);

- var empty = array.getRange(array.length, 0);

+ var empty = array.sublist(array.length, array.length);

Expect.equals(0, empty.length);

- var region = array.getRange(3, array.length - 6);

+ var region = array.sublist(3, array.length - 3);

Expect.isTrue(copy is Int16List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -340,7 +340,7 @@ class ByteArrayTest {

Expect.throws(() { new Int16List(-1); },

(e) { return e is ArgumentError; });

Expect.throws(() { new Int16List.transferable(-1); },

- (e) { return e is ArgumentError; });

+ (e) { return e is ArgumentError; });

var array = new Int16List(10);

testInt16ListImpl(array);

array = new Int16List.transferable(10);

@@ -400,14 +400,14 @@ class ByteArrayTest {

for (int i = 0; i < array.length; ++i) {

array[i] = i;

}

- var copy = array.getRange(0, array.length);

+ var copy = array.sublist(0, array.length);

Expect.isFalse(copy === array);

Expect.isTrue(copy is Uint16List);

Expect.equals(10, copy.length);

Expect.listEquals(array, copy);

- var empty = array.getRange(array.length, 0);

+ var empty = array.sublist(array.length, array.length);

Expect.equals(0, empty.length);

- var region = array.getRange(3, array.length - 6);

+ var region = array.sublist(3, array.length - 3);

Expect.isTrue(copy is Uint16List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -498,14 +498,14 @@ class ByteArrayTest {

for (int i = 0; i < array.length; ++i) {

array[i] = i;

}

- var copy = array.getRange(0, array.length);

+ var copy = array.sublist(0, array.length);

Expect.isFalse(copy === array);

Expect.isTrue(copy is Int32List);

Expect.equals(10, copy.length);

Expect.listEquals(array, copy);

- var empty = array.getRange(array.length, 0);

+ var empty = array.sublist(array.length, array.length);

Expect.equals(0, empty.length);

- var region = array.getRange(3, array.length - 6);

+ var region = array.sublist(3, array.length - 3);

Expect.isTrue(copy is Int32List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -581,14 +581,14 @@ class ByteArrayTest {

for (int i = 0; i < array.length; ++i) {

array[i] = i;

}

- var copy = array.getRange(0, array.length);

+ var copy = array.sublist(0, array.length);

Expect.isFalse(copy === array);

Expect.isTrue(copy is Uint32List);

Expect.equals(10, copy.length);

Expect.listEquals(array, copy);

- var empty = array.getRange(array.length, 0);

+ var empty = array.sublist(array.length, array.length);

Expect.equals(0, empty.length);

- var region = array.getRange(3, array.length - 6);

+ var region = array.sublist(3, array.length - 3);

Expect.isTrue(copy is Uint32List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -606,7 +606,7 @@ class ByteArrayTest {

testUint32ListImpl(array);

array = new Uint32List.transferable(10);

testUint32ListImpl(array);

}

static testInt64ListImpl(Int64List array) {

@@ -680,14 +680,14 @@ class ByteArrayTest {

for (int i = 0; i < array.length; ++i) {

array[i] = i;

}

- var copy = array.getRange(0, array.length);

+ var copy = array.sublist(0, array.length);

Expect.isFalse(copy === array);

Expect.isTrue(copy is Int64List);

Expect.equals(10, copy.length);

Expect.listEquals(array, copy);

- var empty = array.getRange(array.length, 0);

+ var empty = array.sublist(array.length, array.length);

Expect.equals(0, empty.length);

- var region = array.getRange(3, array.length - 6);

+ var region = array.sublist(3, array.length - 3);

Expect.isTrue(copy is Int64List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -764,14 +764,14 @@ class ByteArrayTest {

for (int i = 0; i < array.length; ++i) {

array[i] = i;

}

- var copy = array.getRange(0, array.length);

+ var copy = array.sublist(0, array.length);

Expect.isFalse(copy === array);

Expect.isTrue(copy is Uint64List);

Expect.equals(10, copy.length);

Expect.listEquals(array, copy);

- var empty = array.getRange(array.length, 0);

+ var empty = array.sublist(array.length, array.length);

Expect.equals(0, empty.length);

- var region = array.getRange(3, array.length - 6);

+ var region = array.sublist(3, array.length - 3);

Expect.isTrue(copy is Uint64List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -833,14 +833,14 @@ class ByteArrayTest {

for (int i = 0; i < array.length; ++i) {

array[i] = i * 1.0;

}

- var copy = array.getRange(0, array.length);

+ var copy = array.sublist(0, array.length);

Expect.isFalse(copy === array);

Expect.isTrue(copy is Float32List);

Expect.equals(10, copy.length);

Expect.listEquals(array, copy);

- var empty = array.getRange(array.length, 0);

+ var empty = array.sublist(array.length, array.length);

Expect.equals(0, empty.length);

- var region = array.getRange(3, array.length - 6);

+ var region = array.sublist(3, array.length - 3);

Expect.isTrue(copy is Float32List);

Expect.equals(4, region.length);

Expect.listEquals([3.0, 4.0, 5.0, 6.0], region);

@@ -903,14 +903,14 @@ class ByteArrayTest {

for (int i = 0; i < array.length; ++i) {

array[i] = i * 1.0;

}

- var copy = array.getRange(0, array.length);

+ var copy = array.sublist(0, array.length);

Expect.isFalse(copy === array);

Expect.isTrue(copy is Float64List);

Expect.equals(10, copy.length);

Expect.listEquals(array, copy);

- var empty = array.getRange(array.length, 0);

+ var empty = array.sublist(array.length, array.length);

Expect.equals(0, empty.length);

- var region = array.getRange(3, array.length - 6);

+ var region = array.sublist(3, array.length - 3);

Expect.isTrue(copy is Float64List);

Expect.equals(4, region.length);

Expect.listEquals([3.0, 4.0, 5.0, 6.0], region);

@@ -1184,12 +1184,12 @@ class ByteArrayTest {

for (int i = 0; i < view.length; ++i) {

view[i] = i;

}

- var copy = view.getRange(0, view.length);

+ var copy = view.sublist(0, view.length);

Expect.isFalse(copy === view);

Expect.isTrue(copy is Int8List);

Expect.equals(10, copy.length);

Expect.listEquals(view, copy);

- var region = view.getRange(3, view.length - 6);

+ var region = view.sublist(3, view.length - 3);

Expect.isTrue(copy is Int8List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -1299,12 +1299,12 @@ class ByteArrayTest {

for (int i = 0; i < view.length; ++i) {

view[i] = i;

}

- var copy = view.getRange(0, view.length);

+ var copy = view.sublist(0, view.length);

Expect.isFalse(copy === view);

Expect.isTrue(copy is Uint8List);

Expect.equals(10, copy.length);

Expect.listEquals(view, copy);

- var region = view.getRange(3, view.length - 6);

+ var region = view.sublist(3, view.length - 3);

Expect.isTrue(copy is Uint8List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -1435,12 +1435,12 @@ class ByteArrayTest {

for (int i = 0; i < view.length; ++i) {

view[i] = i;

}

- var copy = view.getRange(0, view.length);

+ var copy = view.sublist(0, view.length);

Expect.isFalse(copy === view);

Expect.isTrue(copy is Int16List);

Expect.equals(10, copy.length);

Expect.listEquals(view, copy);

- var region = view.getRange(3, view.length - 6);

+ var region = view.sublist(3, view.length - 3);

Expect.isTrue(copy is Int16List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -1554,12 +1554,12 @@ class ByteArrayTest {

for (int i = 0; i < view.length; ++i) {

view[i] = i;

}

- var copy = view.getRange(0, view.length);

+ var copy = view.sublist(0, view.length);

Expect.isFalse(copy === view);

Expect.isTrue(copy is Uint16List);

Expect.equals(10, copy.length);

Expect.listEquals(view, copy);

- var region = view.getRange(3, view.length - 6);

+ var region = view.sublist(3, view.length - 3);

Expect.isTrue(copy is Uint16List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -1716,12 +1716,12 @@ class ByteArrayTest {

for (int i = 0; i < view.length; ++i) {

view[i] = i;

}

- var copy = view.getRange(0, view.length);

+ var copy = view.sublist(0, view.length);

Expect.isFalse(copy === view);

Expect.isTrue(copy is Int32List);

Expect.equals(10, copy.length);

Expect.listEquals(view, copy);

- var region = view.getRange(3, view.length - 6);

+ var region = view.sublist(3, view.length - 3);

Expect.isTrue(copy is Int32List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -1845,12 +1845,12 @@ class ByteArrayTest {

for (int i = 0; i < view.length; ++i) {

view[i] = i;

}

- var copy = view.getRange(0, view.length);

+ var copy = view.sublist(0, view.length);

Expect.isFalse(copy === view);

Expect.isTrue(copy is Uint32List);

Expect.equals(10, copy.length);

Expect.listEquals(view, copy);

- var region = view.getRange(3, view.length - 6);

+ var region = view.sublist(3, view.length - 3);

Expect.isTrue(copy is Uint32List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -2039,12 +2039,12 @@ class ByteArrayTest {

for (int i = 0; i < view.length; ++i) {

view[i] = i;

}

- var copy = view.getRange(0, view.length);

+ var copy = view.sublist(0, view.length);

Expect.isFalse(copy === view);

Expect.isTrue(copy is Int64List);

Expect.equals(10, copy.length);

Expect.listEquals(view, copy);

- var region = view.getRange(3, view.length - 6);

+ var region = view.sublist(3, view.length - 3);

Expect.isTrue(copy is Int64List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -2203,12 +2203,12 @@ class ByteArrayTest {

for (int i = 0; i < view.length; ++i) {

view[i] = i;

}

- var copy = view.getRange(0, view.length);

+ var copy = view.sublist(0, view.length);

Expect.isFalse(copy === view);

Expect.isTrue(copy is Uint64List);

Expect.equals(10, copy.length);

Expect.listEquals(view, copy);

- var region = view.getRange(3, view.length - 6);

+ var region = view.sublist(3, view.length - 3);

Expect.isTrue(copy is Uint64List);

Expect.equals(4, region.length);

Expect.listEquals([3, 4, 5, 6], region);

@@ -2317,12 +2317,12 @@ class ByteArrayTest {

for (int i = 0; i < view.length; ++i) {

view[i] = i * 1.0;

}

- var copy = view.getRange(0, view.length);

+ var copy = view.sublist(0, view.length);

Expect.isFalse(copy === view);

Expect.isTrue(copy is Float32List);

Expect.equals(10, copy.length);

Expect.listEquals(view, copy);

- var region = view.getRange(3, view.length - 6);

+ var region = view.sublist(3, view.length - 3);

Expect.isTrue(copy is Float32List);

Expect.equals(4, region.length);

Expect.listEquals([3.0, 4.0, 5.0, 6.0], region);

@@ -2426,12 +2426,12 @@ class ByteArrayTest {

for (int i = 0; i < view.length; ++i) {

view[i] = i * 1.0;

}

- var copy = view.getRange(0, view.length);

+ var copy = view.sublist(0, view.length);

Expect.isFalse(copy === view);

Expect.isTrue(copy is Float64List);

Expect.equals(10, copy.length);

Expect.listEquals(view, copy);

- var region = view.getRange(3, view.length - 6);

+ var region = view.sublist(3, view.length - 3);

Expect.isTrue(copy is Float64List);

Expect.equals(4, region.length);

Expect.listEquals([3.0, 4.0, 5.0, 6.0], region);

« runtime/lib/array.dart ('K') | « runtime/tests/vm/dart/byte_array_optimized_test.dart ('k') | samples/swarm/swarm_ui_lib/observable/observable.dart » ('j') | sdk/lib/core/list.dart » ('J')