Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: sdk/lib/svg/dart2js/svg_dart2js.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 library dart.dom.svg; 1 library dart.dom.svg;
2 2
3 import 'dart:async'; 3 import 'dart:async';
4 import 'dart:collection'; 4 import 'dart:collection';
5 import 'dart:html'; 5 import 'dart:html';
6 import 'dart:html_common'; 6 import 'dart:html_common';
7 import 'dart:_js_helper' show Creates, Returns, JavaScriptIndexingBehavior, JSNa me; 7 import 'dart:_js_helper' show Creates, Returns, JavaScriptIndexingBehavior, JSNa me;
8 import 'dart:_foreign_helper' show JS; 8 import 'dart:_foreign_helper' show JS;
9 // DO NOT EDIT - unless you are editing documentation as per: 9 // DO NOT EDIT - unless you are editing documentation as per:
10 // https://code.google.com/p/dart/wiki/ContributingHTMLDocumentation 10 // https://code.google.com/p/dart/wiki/ContributingHTMLDocumentation
(...skipping 3213 matching lines...) Expand 10 before | Expand all | Expand 10 after
3224 } 3224 }
3225 3225
3226 void removeRange(int start, int rangeLength) { 3226 void removeRange(int start, int rangeLength) {
3227 throw new UnsupportedError("Cannot removeRange on immutable List."); 3227 throw new UnsupportedError("Cannot removeRange on immutable List.");
3228 } 3228 }
3229 3229
3230 void insertRange(int start, int rangeLength, [Length initialValue]) { 3230 void insertRange(int start, int rangeLength, [Length initialValue]) {
3231 throw new UnsupportedError("Cannot insertRange on immutable List."); 3231 throw new UnsupportedError("Cannot insertRange on immutable List.");
3232 } 3232 }
3233 3233
3234 List<Length> sublist(int start, [int end]) {
3235 if (end == null) end = length;
3236 return Lists.getRange(this, start, end, <Length>[]);
3237 }
3238
3234 List<Length> getRange(int start, int rangeLength) => 3239 List<Length> getRange(int start, int rangeLength) =>
3235 Lists.getRange(this, start, rangeLength, <Length>[]); 3240 sublist(start, start + rangeLength);
3236 3241
3237 Map<int, Length> asMap() => 3242 Map<int, Length> asMap() =>
3238 IterableMixinWorkaround.asMapList(this); 3243 IterableMixinWorkaround.asMapList(this);
3239 3244
3240 // -- end List<Length> mixins. 3245 // -- end List<Length> mixins.
3241 3246
3242 @DomName('SVGLengthList.appendItem') 3247 @DomName('SVGLengthList.appendItem')
3243 @DocsEditable 3248 @DocsEditable
3244 Length appendItem(Length item) native; 3249 Length appendItem(Length item) native;
3245 3250
(...skipping 611 matching lines...) Expand 10 before | Expand all | Expand 10 after
3857 } 3862 }
3858 3863
3859 void removeRange(int start, int rangeLength) { 3864 void removeRange(int start, int rangeLength) {
3860 throw new UnsupportedError("Cannot removeRange on immutable List."); 3865 throw new UnsupportedError("Cannot removeRange on immutable List.");
3861 } 3866 }
3862 3867
3863 void insertRange(int start, int rangeLength, [Number initialValue]) { 3868 void insertRange(int start, int rangeLength, [Number initialValue]) {
3864 throw new UnsupportedError("Cannot insertRange on immutable List."); 3869 throw new UnsupportedError("Cannot insertRange on immutable List.");
3865 } 3870 }
3866 3871
3872 List<Number> sublist(int start, [int end]) {
3873 if (end == null) end = length;
3874 return Lists.getRange(this, start, end, <Number>[]);
3875 }
3876
3867 List<Number> getRange(int start, int rangeLength) => 3877 List<Number> getRange(int start, int rangeLength) =>
3868 Lists.getRange(this, start, rangeLength, <Number>[]); 3878 sublist(start, start + rangeLength);
3869 3879
3870 Map<int, Number> asMap() => 3880 Map<int, Number> asMap() =>
3871 IterableMixinWorkaround.asMapList(this); 3881 IterableMixinWorkaround.asMapList(this);
3872 3882
3873 // -- end List<Number> mixins. 3883 // -- end List<Number> mixins.
3874 3884
3875 @DomName('SVGNumberList.appendItem') 3885 @DomName('SVGNumberList.appendItem')
3876 @DocsEditable 3886 @DocsEditable
3877 Number appendItem(Number item) native; 3887 Number appendItem(Number item) native;
3878 3888
(...skipping 887 matching lines...) Expand 10 before | Expand all | Expand 10 after
4766 } 4776 }
4767 4777
4768 void removeRange(int start, int rangeLength) { 4778 void removeRange(int start, int rangeLength) {
4769 throw new UnsupportedError("Cannot removeRange on immutable List."); 4779 throw new UnsupportedError("Cannot removeRange on immutable List.");
4770 } 4780 }
4771 4781
4772 void insertRange(int start, int rangeLength, [PathSeg initialValue]) { 4782 void insertRange(int start, int rangeLength, [PathSeg initialValue]) {
4773 throw new UnsupportedError("Cannot insertRange on immutable List."); 4783 throw new UnsupportedError("Cannot insertRange on immutable List.");
4774 } 4784 }
4775 4785
4786 List<PathSeg> sublist(int start, [int end]) {
4787 if (end == null) end = length;
4788 return Lists.getRange(this, start, end, <PathSeg>[]);
4789 }
4790
4776 List<PathSeg> getRange(int start, int rangeLength) => 4791 List<PathSeg> getRange(int start, int rangeLength) =>
4777 Lists.getRange(this, start, rangeLength, <PathSeg>[]); 4792 sublist(start, start + rangeLength);
4778 4793
4779 Map<int, PathSeg> asMap() => 4794 Map<int, PathSeg> asMap() =>
4780 IterableMixinWorkaround.asMapList(this); 4795 IterableMixinWorkaround.asMapList(this);
4781 4796
4782 // -- end List<PathSeg> mixins. 4797 // -- end List<PathSeg> mixins.
4783 4798
4784 @DomName('SVGPathSegList.appendItem') 4799 @DomName('SVGPathSegList.appendItem')
4785 @DocsEditable 4800 @DocsEditable
4786 PathSeg appendItem(PathSeg newItem) native; 4801 PathSeg appendItem(PathSeg newItem) native;
4787 4802
(...skipping 872 matching lines...) Expand 10 before | Expand all | Expand 10 after
5660 } 5675 }
5661 5676
5662 void removeRange(int start, int rangeLength) { 5677 void removeRange(int start, int rangeLength) {
5663 throw new UnsupportedError("Cannot removeRange on immutable List."); 5678 throw new UnsupportedError("Cannot removeRange on immutable List.");
5664 } 5679 }
5665 5680
5666 void insertRange(int start, int rangeLength, [String initialValue]) { 5681 void insertRange(int start, int rangeLength, [String initialValue]) {
5667 throw new UnsupportedError("Cannot insertRange on immutable List."); 5682 throw new UnsupportedError("Cannot insertRange on immutable List.");
5668 } 5683 }
5669 5684
5685 List<String> sublist(int start, [int end]) {
5686 if (end == null) end = length;
5687 return Lists.getRange(this, start, end, <String>[]);
5688 }
5689
5670 List<String> getRange(int start, int rangeLength) => 5690 List<String> getRange(int start, int rangeLength) =>
5671 Lists.getRange(this, start, rangeLength, <String>[]); 5691 sublist(start, start + rangeLength);
5672 5692
5673 Map<int, String> asMap() => 5693 Map<int, String> asMap() =>
5674 IterableMixinWorkaround.asMapList(this); 5694 IterableMixinWorkaround.asMapList(this);
5675 5695
5676 // -- end List<String> mixins. 5696 // -- end List<String> mixins.
5677 5697
5678 @DomName('SVGStringList.appendItem') 5698 @DomName('SVGStringList.appendItem')
5679 @DocsEditable 5699 @DocsEditable
5680 String appendItem(String item) native; 5700 String appendItem(String item) native;
5681 5701
(...skipping 1149 matching lines...) Expand 10 before | Expand all | Expand 10 after
6831 } 6851 }
6832 6852
6833 void removeRange(int start, int rangeLength) { 6853 void removeRange(int start, int rangeLength) {
6834 throw new UnsupportedError("Cannot removeRange on immutable List."); 6854 throw new UnsupportedError("Cannot removeRange on immutable List.");
6835 } 6855 }
6836 6856
6837 void insertRange(int start, int rangeLength, [Transform initialValue]) { 6857 void insertRange(int start, int rangeLength, [Transform initialValue]) {
6838 throw new UnsupportedError("Cannot insertRange on immutable List."); 6858 throw new UnsupportedError("Cannot insertRange on immutable List.");
6839 } 6859 }
6840 6860
6861 List<Transform> sublist(int start, [int end]) {
6862 if (end == null) end = length;
6863 return Lists.getRange(this, start, end, <Transform>[]);
6864 }
6865
6841 List<Transform> getRange(int start, int rangeLength) => 6866 List<Transform> getRange(int start, int rangeLength) =>
6842 Lists.getRange(this, start, rangeLength, <Transform>[]); 6867 sublist(start, start + rangeLength);
6843 6868
6844 Map<int, Transform> asMap() => 6869 Map<int, Transform> asMap() =>
6845 IterableMixinWorkaround.asMapList(this); 6870 IterableMixinWorkaround.asMapList(this);
6846 6871
6847 // -- end List<Transform> mixins. 6872 // -- end List<Transform> mixins.
6848 6873
6849 @DomName('SVGTransformList.appendItem') 6874 @DomName('SVGTransformList.appendItem')
6850 @DocsEditable 6875 @DocsEditable
6851 Transform appendItem(Transform item) native; 6876 Transform appendItem(Transform item) native;
6852 6877
(...skipping 506 matching lines...) Expand 10 before | Expand all | Expand 10 after
7359 } 7384 }
7360 7385
7361 void removeRange(int start, int rangeLength) { 7386 void removeRange(int start, int rangeLength) {
7362 throw new UnsupportedError("Cannot removeRange on immutable List."); 7387 throw new UnsupportedError("Cannot removeRange on immutable List.");
7363 } 7388 }
7364 7389
7365 void insertRange(int start, int rangeLength, [ElementInstance initialValue]) { 7390 void insertRange(int start, int rangeLength, [ElementInstance initialValue]) {
7366 throw new UnsupportedError("Cannot insertRange on immutable List."); 7391 throw new UnsupportedError("Cannot insertRange on immutable List.");
7367 } 7392 }
7368 7393
7394 List<ElementInstance> sublist(int start, [int end]) {
7395 if (end == null) end = length;
7396 return Lists.getRange(this, start, end, <ElementInstance>[]);
7397 }
7398
7369 List<ElementInstance> getRange(int start, int rangeLength) => 7399 List<ElementInstance> getRange(int start, int rangeLength) =>
7370 Lists.getRange(this, start, rangeLength, <ElementInstance>[]); 7400 sublist(start, start + rangeLength);
7371 7401
7372 Map<int, ElementInstance> asMap() => 7402 Map<int, ElementInstance> asMap() =>
7373 IterableMixinWorkaround.asMapList(this); 7403 IterableMixinWorkaround.asMapList(this);
7374 7404
7375 // -- end List<ElementInstance> mixins. 7405 // -- end List<ElementInstance> mixins.
7376 7406
7377 @DomName('SVGElementInstanceList.item') 7407 @DomName('SVGElementInstanceList.item')
7378 @DocsEditable 7408 @DocsEditable
7379 ElementInstance item(int index) native; 7409 ElementInstance item(int index) native;
7380 } 7410 }
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
7783 7813
7784 7814
7785 @DocsEditable 7815 @DocsEditable
7786 @DomName('SVGVKernElement') 7816 @DomName('SVGVKernElement')
7787 class _SVGVKernElement extends SvgElement native "*SVGVKernElement" { 7817 class _SVGVKernElement extends SvgElement native "*SVGVKernElement" {
7788 7818
7789 @DomName('SVGVKernElement.SVGVKernElement') 7819 @DomName('SVGVKernElement.SVGVKernElement')
7790 @DocsEditable 7820 @DocsEditable
7791 factory _SVGVKernElement() => _SvgElementFactoryProvider.createSvgElement_tag( "vkern"); 7821 factory _SVGVKernElement() => _SvgElementFactoryProvider.createSvgElement_tag( "vkern");
7792 } 7822 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698